Skip to content

[PWGCF] jEPFlowAnalysis.cxx: fix bug for initialization - #17583

Merged
wenyaCern merged 5 commits into
AliceO2Group:masterfrom
jikim1290:cf12
Aug 25, 2026
Merged

[PWGCF] jEPFlowAnalysis.cxx: fix bug for initialization#17583
wenyaCern merged 5 commits into
AliceO2Group:masterfrom
jikim1290:cf12

Conversation

@jikim1290

Copy link
Copy Markdown
Contributor

fix bug for initialization

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d7b8010 at 2026-08-25 04:45:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ddcd2a1 at 2026-08-25 05:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 33 warnings.'
Found 4 errors and 33 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/36ad69654248866441e2eccf6031c27663620836/O2Physics-code-check/errors.txt
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:75:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:247:31: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:271:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:583:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
++ [[ 33 -gt 0 ]]
++ cat /sw/BUILD/36ad69654248866441e2eccf6031c27663620836/O2Physics-code-check/warnings.txt
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:207:40: warning: initializer for member 'shiftprofile' is redundant [readability-redundant-member-init]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:218:37: warning: initializer for member 'ft0RelGainConst' is redundant [readability-redundant-member-init]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:219:37: warning: initializer for member 'fv0RelGainConst' is redundant [readability-redundant-member-init]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:235:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:249:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:269:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:273:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:277:136: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:282:120: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:286:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:291:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:294:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:374:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:375:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:376:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:448:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:465:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:470:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:473:134: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:476:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:532:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:577:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:658:9: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:669:9: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:685:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:768:122: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:777:9: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:782:9: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:798:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:818:11: warning: implicit conversion 'uint8_t' (aka 'unsigned char') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:833:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:846:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:856:43: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 4 -gt 0 ]]
++ exit 1
--
[0 more errors; see full log]

Full log here.

jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Aug 25, 2026
Please consider the following formatting changes to AliceO2Group#17583
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d3deb6e at 2026-08-25 06:18:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:246:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 74e663d at 2026-08-25 06:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:246:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 74e663d at 2026-08-25 06:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:246:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Aug 25, 2026
Please consider the following formatting changes to AliceO2Group#17583
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 74e663d at 2026-08-25 06:38:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/06f0efa9668031b7756a0dd1cfe66b2e6385d9ca/O2Physics-code-check/errors.txt
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:246:3: error: non-void function does not return a value in all control paths [clang-diagnostic-return-type,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@wenyaCern
wenyaCern merged commit f2f8950 into AliceO2Group:master Aug 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants