Skip to content

[PWGLF] heavyionmultiplicity.cxx - #17586

Merged
abmodak merged 1 commit into
AliceO2Group:masterfrom
murioni:master
Aug 25, 2026
Merged

[PWGLF] heavyionmultiplicity.cxx#17586
abmodak merged 1 commit into
AliceO2Group:masterfrom
murioni:master

Conversation

@murioni

@murioni murioni commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

fixing FT0Manchor multiplicity selection for event loss

@github-actions github-actions Bot added the pwglf label Aug 25, 2026
@murioni
murioni marked this pull request as draft August 25, 2026 09:16
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 5 errors, ⚠️ 1 warnings, 🔕 0 disabled

@murioni
murioni marked this pull request as ready for review August 25, 2026 09:19
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2284eed at 2026-08-25 12:01:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 20 errors and 20 warnings.'
Found 20 errors and 20 warnings.
++ [[ 20 -gt 0 ]]
++ cat /sw/BUILD/7e21c20da1ba1be21971b789ca589f5b925da1b1/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:134:10: error: variable 'axisEvent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:135:10: error: variable 'axisVtxZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:136:10: error: variable 'axisEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:137:10: error: variable 'axisEtaExtended' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:138:10: error: variable 'axisPhi' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:139:10: error: variable 'axisPhi2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:140:10: error: variable 'axisTrackType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:141:10: error: variable 'axisGenPtVary' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:142:10: error: variable 'axisSpecies' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:143:10: error: variable 'axisGenTrkType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:144:10: error: variable 'axisRecTrkType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:145:10: error: variable 'axisMassK0s' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:146:10: error: variable 'axisMassLambda' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:147:10: error: variable 'axisTracks' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:148:10: error: variable 'axisDeltaEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:153:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:677:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:679:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:985:17: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:986:17: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 20 -gt 0 ]]
++ cat /sw/BUILD/7e21c20da1ba1be21971b789ca589f5b925da1b1/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:69:1: warning: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:77:1: warning: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:85:1: warning: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:99:1: warning: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:109:1: warning: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:516:85: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:518:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:569:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:592:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:595:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:676:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:678:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:801:15: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:888:23: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:925:9: warning: do not use 'else' after 'continue' [readability-else-after-return]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1097:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1100:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1103:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1107:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1109:55: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@abmodak
abmodak merged commit e075ac4 into AliceO2Group:master Aug 25, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants