[PWGEM] add photon skimmer in photonbuilder - #17591
Merged
Merged
Conversation
|
O2 linter results: ❌ 34 errors, |
github-actions
Bot
changed the title
Steffimro
marked this pull request as ready for review
August 25, 2026 13:17
Steffimro
requested review from
alibuild,
amaringarcia,
dsekihat,
feisenhu,
hscheid,
jokonig,
mhemmer-cern,
mikesas,
rbailhac and
reygers
as code owners
August 25, 2026 13:17
jokonig
reviewed
Aug 25, 2026
| using MyCollisions = soa::Join<aod::Collisions, aod::EvSels, aod::EMEvSels, aod::CentFT0Ms, aod::CentFT0As, aod::CentFT0Cs>; | ||
| // using MyCollisionsWithSWT = soa::Join<MyCollisions, aod::EMSWTriggerBitsTMP>; | ||
| using MyCollisionsMC = soa::Join<MyCollisions, aod::McCollisionLabels>; | ||
| using MyBCs = soa::Join<aod::BCsWithTimestamps, aod::PcmObjects>; |
Collaborator
There was a problem hiding this comment.
Why is this changed/removed?
Collaborator
|
Error while checking build/O2Physics/code-check for b633a7a at 2026-08-25 16:24: Full log here. |
jokonig
approved these changes
Aug 25, 2026
jokonig
enabled auto-merge (squash)
August 25, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the filterEOI task runs over the V0photonKF table, it is better to include the skimmer in the photon builder itself in order to reduce the data set size. The same idea as in filterEOI is now implemented in the photonconversionbuilder.
Additionally, configurable groups where implemented in order to allow an easier selection of the photon selection criteria in the photon conversion builder.