Skip to content

[PWGCF] Modified the MC reconstructed task - #17613

Open
SwatiSaha-1997 wants to merge 2 commits into
AliceO2Group:masterfrom
SwatiSaha-1997:master
Open

[PWGCF] Modified the MC reconstructed task#17613
SwatiSaha-1997 wants to merge 2 commits into
AliceO2Group:masterfrom
SwatiSaha-1997:master

Conversation

@SwatiSaha-1997

Copy link
Copy Markdown
Collaborator

[1] When multiple reconstructed collisions map to the same generated MC collision, keep only the one with the most contributors and discard the rest
[2] Changed the filename to fix o2-linter error in the CMakeLists.txt file

@github-actions github-actions Bot added the pwgcf label Aug 26, 2026
@github-actions github-actions Bot changed the title Modified the MC reconstructed task [PWGCF] Modified the MC reconstructed task Aug 26, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@SwatiSaha-1997
SwatiSaha-1997 enabled auto-merge (squash) August 26, 2026 15:09
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 58f1e81 at 2026-08-26 17:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 44 warnings.'
Found 7 errors and 44 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/0b4c8a3a755c3737c84846e1c5253131b3915ecd/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:36:1: error: included header PID.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:59:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:61:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:353:33: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:387:41: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:429:45: error: the parameter 'coll' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:530:14: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 44 -gt 0 ]]
++ cat /sw/BUILD/0b4c8a3a755c3737c84846e1c5253131b3915ecd/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:322:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:324:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:326:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:328:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:330:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:332:56: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:334:54: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:336:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:365:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:370:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:372:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:374:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:376:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:378:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:380:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:393:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:395:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:400:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:402:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:407:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:409:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:414:83: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:416:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:422:183: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:504:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:560:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:565:11: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:595:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:673:99: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:675:122: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:690:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:692:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/meanptFluctuations.cxx:694:55: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@SwatiSaha-1997
SwatiSaha-1997 enabled auto-merge (squash) August 26, 2026 16:34

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @SwatiSaha-1997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants