-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query new gauges API in all remaining places where flows are displayed #588
Comments
beta box changes incorporated into #591 |
flow tab changes incorporated into #591 |
The existing state lists, it turns out, are still Laravel-based – e.g. https://www.americanwhitewater.org/content/River/state-summary/?state=AK. I don't think it makes sense to make changes to the Laravel code-base to incorporate retrieving data from the new gauge API, which leaves us with two options:
|
I think if it's not too much work, getting the state-by-state tab into vue makes sense to me. |
does an API already exist to support this? I'll look but you may know off the top of your head if the mobile app is doing something similar. I would need: query reaches by state and include correlation details with the response @tallowen |
@ngottlieb - we don't have that API yet - the mobile app does all of it's sorting/filtering client side after it already has all of the information right now. |
Tweaks from @AWKevin after initial review:
|
Additional tweaks from @AWKevin
|
this PR https://github.com/AmericanWhitewater/aw-components/pull/354 supports a new endpoint for a better approach to displaying flow data in the NWI map table. pending its release:
|
Updating description with ongoing todo list from comments:
The text was updated successfully, but these errors were encountered: