Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg 4697 12.4 initial #1

Merged
merged 3 commits into from
May 10, 2024
Merged

Pkg 4697 12.4 initial #1

merged 3 commits into from
May 10, 2024

Conversation

danpetry
Copy link

@danpetry danpetry commented May 7, 2024 •
edited by jira bot
Loading

Destination channel: defaults

Links

Explanation of changes:

  • Part of CUDA 12.4 build, following conda-forge's pattern which was developed in conjunction with Nvidia. There isn't a need to stage these then release them all at once. They won't cause a problem released one at a time.
  • Please check the main branch too, this has just been forked
  • Changes made to adjust feedstocks for differences between conda-forge and defaults. Please see commit messages for description of changes.

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_44o1q2h52m/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:45: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:21: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:45: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:45: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:22: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:23: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
    ===== Final Report: =====
    5 Errors and 1 Warning were found

@danpetry danpetry closed this May 8, 2024
@danpetry danpetry reopened this May 8, 2024
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_4206l2cr_a/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:45: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:45: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:22: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:45: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:23: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:21: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
    ===== Final Report: =====
    5 Errors and 1 Warning were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_d6jabrpzgi/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:46: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:23: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:22: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:46: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:24: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:46: missing_dev_url: The recipe is missing a dev_url
    ===== Final Report: =====
    5 Errors and 1 Warning were found

skupr-anaconda
skupr-anaconda approved these changes May 9, 2024
View reviewed changes
Copy link

@skupr-anaconda skupr-anaconda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite unusual to see a noarch package and compiler stuff at runtime. Is it somewhere described in docs to learn more about it?

cbouss
cbouss reviewed May 9, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_6cs5sec6_9/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:46: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:22: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:23: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:24: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:46: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:46: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    5 Errors and 1 Warning were found

@danpetry
Copy link
Author

@skupr-anaconda in general the reasoning is in the conda-forge recipe in some issue or PR, eg. conda-forge#3 gives some info
also there's a lot of discussion here conda-forge/conda-forge.github.io#1963

@danpetry
Copy link
Author

in this case, it's a metapackage, so it's just a way to pull in other packages when used (which need to be run dependencies because otherwise it won't do that). It doesn't need to be arch-specific. It just happens to be one that groups a bunch of compilers.

@danpetry @cbouss
Skip non-applicable packages
440438d 
On conda-forge this is handled in the CI config files

Co-authored-by: Charles Bousseau <16641587+cbouss@users.noreply.github.com>
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_46kfs8ia6i/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:46: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:46: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:24: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:23: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:22: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:46: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    5 Errors and 1 Warning were found

@danpetry danpetry merged commit 218c097 into main May 10, 2024
7 of 8 checks passed
@danpetry danpetry deleted the PKG-4697-12.4-initial branch May 10, 2024 20:09
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_76v26yhxkh/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:46: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:22: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:23: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:24: compilers_must_be_in_build: The recipe requests a compiler in a section other than build
  • clone/recipe/meta.yaml:46: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:46: missing_dev_url: The recipe is missing a dev_url
    ===== Final Report: =====
    5 Errors and 1 Warning were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skupr-anaconda skupr-anaconda skupr-anaconda approved these changes

@cbouss cbouss cbouss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danpetry @anaconda-pkg-build @cbouss @skupr-anaconda