Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Overlaps Content on Scroll - Needs Fixed Positioning #68

Closed
wants to merge 1 commit into from

Conversation

saadgibawa
Copy link

@saadgibawa saadgibawa commented Oct 2, 2024

Description

Solved the issue of header overlapping the content on scrolling by making changes :-

  1. Added a script in index.html file to change the navbar background from transparent to brown when scrolling down.
  2. Implemented transition for a smoother change in background color.
  3. Updated .navbar in style.css file to initially have a transparent background and a smooth color transition effect.

Related Issues

None

Type of PR

  • (Enhancement)

Screenshots / videos (if applicable)

Screenshot 2024-10-02 155746
Screenshot 2024-10-02 155820

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

vercel bot commented Oct 2, 2024

Deployment failed with the following error:

Resource is limited - try again in 5 hours (more than 100, code: "api-deployments-free-per-day").

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @saadgibawa! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@saadgibawa saadgibawa changed the title Header Overlaps Content on Scroll - Needs Fixed Positioning #4 Header Overlaps Content on Scroll - Needs Fixed Positioning Oct 2, 2024
@Anjaliavv51
Copy link
Owner

@saadgibawa please add related issues number

@saadgibawa
Copy link
Author

@Anjaliavv51 issue no. #4

@saadgibawa
Copy link
Author

@Anjaliavv51 Please review the changes, and let me know if any further adjustments are needed!

@saadgibawa
Copy link
Author

Hi @Anjaliavv51
I noticed that the pull request I submitted was closed without merging. I would appreciate it if you could provide some feedback on what was wrong with the changes I made. I'm eager to learn and improve, and I'm more than happy to make any necessary adjustments.
Please let me know if there are specific issues that need to be addressed or if I can submit a revised version of the PR.
Thank you for your time and consideration.

@Anjaliavv51
Copy link
Owner

Hi @Anjaliavv51 I noticed that the pull request I submitted was closed without merging. I would appreciate it if you could provide some feedback on what was wrong with the changes I made. I'm eager to learn and improve, and I'm more than happy to make any necessary adjustments. Please let me know if there are specific issues that need to be addressed or if I can submit a revised version of the PR. Thank you for your time and consideration.

Sorry to not to inform , it is already done.

@saadgibawa
Copy link
Author

@Anjaliavv51 No problem, thank you for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header Overlaps Content on Scroll - Needs Fixed Positioning
2 participants