✨[feature Request]: Enable PWA for the site #704
+83
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @mohammedanaf! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for rococo-mooncake-0d89f7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@Anjaliavv51 the site is pwa-enabled and this PR is awaiting your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The website is now a Progressive Web Application where users can install it as a desktop or mobile application and access it easily. Not only that; it also provides offline access by pre-downloading assets mentioned in
service-worker.jsfor faster reloading.Related Issues
Type of PR
Screenshots / videos (if applicable)
https://www.loom.com/share/635a2d108ff7426a9fb0eb06a61371cc?sid=c520bb83-74c0-4950-8749-5a80a04f3f37
Checklist
mainbranch before making this PRAdditional context:
I have modified
index.htmlwith an inline comment to linkmanifest.json. I have also added two other files namedmanifest.jsonandservice-worker.jsfor enabling PWA. I have also added a service worker script inindex.htmlat the bottom with an inline comment to detectservice-worker.jsfile in the root of the folder. I have also resized favicons to 192x192 and 512x512 format for app icon in different screen sizes.