Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/zero at decrease nominal #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

swarawan
Copy link

@swarawan swarawan commented Oct 1, 2018

Base idea:
On making library, we need to let user choose they needs, and strict minimum value to one instead of zero is not a good idea, because we don't know what user needs for this library. This library is simple but perfect. But lack of user needs if they want to decrease to zero or even minus value.

So my PR is about to:

  • change default value to zero instead of one.
  • support minus value by using setMinus(boolean) method. Default is false
  • add more margin on value view to prevent cut text if counted to hundred and more
  • update SDK Build for future sake

@swarawan swarawan closed this Oct 1, 2018
@swarawan swarawan deleted the fix/zero-at-decrease-nominal branch October 1, 2018 06:39
@swarawan swarawan restored the fix/zero-at-decrease-nominal branch October 1, 2018 06:39
@swarawan swarawan reopened this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant