feat: support block id for provider get_code() [APE-1203]
#1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
get_code() [APE-1203]
antazoey
commented
Jul 18, 2023
| @@ -200,12 +200,13 @@ def get_balance(self, address: AddressType) -> int: | |||
| """ | |||
|
|
|||
| @abstractmethod | |||
| def get_code(self, address: AddressType) -> ContractCode: | |||
| def get_code(self, address: AddressType, **kwargs) -> ContractCode: | |||
There was a problem hiding this comment.
so i made sure, we are allowed to add **kwargs to abstract methods without it breaking the plugins that override and dont yet have it
3 tasks
fubuloubu
approved these changes
Jul 18, 2023
If you want this in 0.7, make sure it is in the 0.7 project (or tag, i forget) on linear and itll for sure get in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #1540
How I did it
How to verify it
Checklist