Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: networks run CLI [APE-981] #1576

Merged
merged 9 commits into from
Aug 1, 2023
Merged

feat: networks run CLI [APE-981] #1576

merged 9 commits into from
Aug 1, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Aug 1, 2023

What I did

A CLI for starting development nodes

fixes: #1453
fixes: ApeWorX/ape-hardhat#128
Fixes: APE-981
Fixes: APE-725

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu previously approved these changes Aug 1, 2023
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Two comments

src/ape_networks/_cli.py Outdated Show resolved Hide resolved
tests/integration/cli/test_networks.py Outdated Show resolved Hide resolved
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
@antazoey
Copy link
Member Author

antazoey commented Aug 1, 2023

  • needing to do some adjustments as I actually use this

@antazoey
Copy link
Member Author

antazoey commented Aug 1, 2023

Screenshot 2023-08-01 at 11 08 05

Now your output looks identical as if you were running the process yourself!

@antazoey antazoey requested a review from fubuloubu August 1, 2023 16:08
fubuloubu
fubuloubu previously approved these changes Aug 1, 2023
@antazoey antazoey merged commit 3a0bf34 into ApeWorX:main Aug 1, 2023
16 checks passed
@antazoey antazoey deleted the feat/node branch August 1, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants