feat(query): contract creation query support [APE-1296] #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
Merged
3 tasks
fubuloubu
commented
Aug 17, 2023
z80dev
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR moves the
get_creation_receiptto be a query that is supported in the query system. The goal is that now that it's in the query system, it can be supported by faster query engines vs. brute force search (such as etherscan) to speed up the capability of the search (and also help resolve the bug noted in #1593)How I did it
This is only a partial fix to #1593, there are still more fixes needed to the brute force method in core (so it can resolve the issue mentioned more effectively/efficiently)
How to verify it
Mostly a refactor, so if tests work 🤷
Checklist
- [ ] New test cases have been added- [ ] Documentation has been updated