-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rewrite poll methods with new API [APE-1411] #1673
Conversation
APE-1411 "feat: rewrite poll methods with new API" (ApeWorX/ape #1673)
What I didImplemented new poll_blocks and poll_events methods in the ProviderAPI fixes: #1669 How I did itUsed the new Web3.py filter objects for polling of new blocks and events. The event polling uses the block polling for confirmations so as to not repeat that logic in both functions. How to verify itChecklist
ApeWorX/ape #1673 by z80dev on GitHub via LinearSync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a question re: confirmations at the filter level!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these comments in case they help but I am going to debug now.
This reverts commit 84a3180.
b678c47
to
91b894a
Compare
now we're catching a ProviderError, not a ChainError
also includes ignoring an invalid warning due to pydantic _compat
What I did
Implemented new poll_blocks and poll_events methods in the ProviderAPI
fixes: #1669
How I did it
Used the new Web3.py filter objects for polling of new blocks and events. The event polling uses the block polling for confirmations so as to not repeat that logic in both functions.
How to verify it
Checklist