feat!: rewrite poll methods with new API [APE-1411] #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
APE-1411 "feat: rewrite poll methods with new API" (ApeWorX/ape #1673)
What I didImplemented new poll_blocks and poll_events methods in the ProviderAPI fixes: #1669 How I did itUsed the new Web3.py filter objects for polling of new blocks and events. The event polling uses the block polling for confirmations so as to not repeat that logic in both functions. How to verify itChecklist
ApeWorX/ape #1673 by z80dev on GitHub via LinearSync |
antazoey
reviewed
Sep 25, 2023
fubuloubu
reviewed
Sep 26, 2023
antazoey
reviewed
Sep 26, 2023
antazoey
reviewed
Sep 29, 2023
z80dev
changed the title
antazoey
reviewed
Nov 6, 2023
antazoey
reviewed
Nov 6, 2023
This reverts commit 84a3180.
antazoey
force-pushed
the
poll-methods-redux
branch
from
b678c47
to
91b894a
Compare
antazoey
reviewed
Nov 7, 2023
antazoey
reviewed
Nov 7, 2023
antazoey
reviewed
Nov 7, 2023
now we're catching a ProviderError, not a ChainError
also includes ignoring an invalid warning due to pydantic _compat
antazoey
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implemented new poll_blocks and poll_events methods in the ProviderAPI
fixes: #1669
How I did it
Used the new Web3.py filter objects for polling of new blocks and events. The event polling uses the block polling for confirmations so as to not repeat that logic in both functions.
How to verify it
Checklist