Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: pydantic v2 upgrade [APE-1413] #1674

Merged
merged 22 commits into from
Dec 9, 2023

Conversation

antazoey
Copy link
Member

What I did

fixes: #

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title feat!: pydantic v2 upgrade feat!: pydantic v2 upgrade [APE-1413] Sep 25, 2023
@antazoey
Copy link
Member Author

will rebase after #1675 and #1676

@antazoey antazoey force-pushed the feat/upgrade-pydantic-v2 branch 4 times, most recently from be5d04e to 160a2ca Compare October 2, 2023 20:52
@antazoey antazoey force-pushed the feat/upgrade-pydantic-v2 branch 2 times, most recently from 5da3506 to 3a4d365 Compare October 13, 2023 18:50
src/ape/types/address.py Outdated Show resolved Hide resolved
Copy link

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Nov 13, 2023
@NotPeopling2day NotPeopling2day removed the stale No activity for 30 days label Nov 13, 2023
@antazoey antazoey force-pushed the feat/upgrade-pydantic-v2 branch 2 times, most recently from f83271f to e79b295 Compare November 17, 2023 14:25
fubuloubu
fubuloubu previously approved these changes Nov 18, 2023
setup.py Outdated
"ethpm-types>=0.5.10,<0.6",
"evm-trace>=0.1.0a23",
"ethpm-types>=0.6.0,<0.7",
"eth_pydantic_types>=0.1.0a3,<0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how close is this to a beta/full release?

Copy link
Member Author

@antazoey antazoey Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a fairly simple package. id say after ape 0.7 is out, the very next release of eth_pydantic_types can be official but will be good to see what happens after 0.7

@antazoey antazoey marked this pull request as ready for review December 8, 2023 20:29
@antazoey antazoey changed the title feat!: pydantic v2 upgrade [APE-1413] refactor!: pydantic v2 upgrade [APE-1413] Dec 8, 2023
@antazoey antazoey enabled auto-merge (squash) December 9, 2023 00:38
Copy link
Contributor

@NotPeopling2day NotPeopling2day left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingers crossed

@antazoey antazoey merged commit 82a9f9e into ApeWorX:main Dec 9, 2023
15 checks passed
@antazoey antazoey deleted the feat/upgrade-pydantic-v2 branch December 9, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants