fix: issue with custom errors on estimate gas and static fee txns [APE-1421] #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
fubuloubu
previously approved these changes
Sep 27, 2023
antazoey
force-pushed
the
fix/static-tx-custom-err
branch
from
f7b5ffb
to
a440b22
Compare
fubuloubu
previously approved these changes
Sep 28, 2023
fubuloubu
previously approved these changes
Sep 28, 2023
fubuloubu
previously approved these changes
Sep 28, 2023
fubuloubu
previously approved these changes
Sep 28, 2023
antazoey
force-pushed
the
fix/static-tx-custom-err
branch
from
36b92e9
to
25b444c
Compare
fubuloubu
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #1668
Fixes: APE-1402
How I did it
Honor networks gas settings during tx prepartion (only was issue on the Static fee txns)
How to verify it
Here is a screenshot showing it working, i am using the same example as from the linked issue:
Checklist