perf: lazily load plugins [APE-1422] #1681
Conversation
vany365
changed the title
|
seeing about a 12% performance improvement with this on my machine 🚀 |
* feat(query): add timestamp to ContractLog fixes: ApeWorX#1612 * docs: add docstring to timestamp property of ContractLog * test: add test for ContractLog.timestamp
My goal right now is to not load plugins for any of the help-commands e.g.
but disclaimer here: if you run any cmd that loads plugins, there shouldnt be any performance gains by this PR alone. in the future, we want to load only plugins needed but thatll likely require a bigger refactor |
You will see a bigger one on commands like Main: |
| _T = TypeVar("_T") # _LazySequence generic. | ||
|
|
||
|
|
||
| class _LazySequence(Sequence[_T]): |
There was a problem hiding this comment.
at this time, this is only really used in internal stuff in the framework for performance reasons; i tried using collections.deque() but it wasnt lazily enough and so i went with this but if there is way to make deque not iterate at all upon init, that would be nice, or an alternative data structure
What I did
This shaves almost a second off of
time ape. None of the plugins are loaded if they are not needed (but they are loaded if they are needed).How I did it
Use iterators mostly.
How to verify it
Checklist