fix: ape plugins list failed when no plugins installed. [APE-1425]
#1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
ape plugins list failed when no plugins installed.ape plugins list failed when no plugins installed. [APE-1425]
antazoey
commented
Sep 29, 2023
| @@ -351,6 +351,8 @@ def test_get_project_figure_out_contracts_path(project): | |||
| to figure it out. | |||
| """ | |||
| project_path = WITH_DEPS_PROJECT / "renamed_contracts_folder" | |||
| (project_path / "ape-config.yaml").unlink(missing_ok=True) # Clean from prior. | |||
There was a problem hiding this comment.
hoping this addresses an intermittent failure i can not explain....
fubuloubu
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
got an unhandled exception when attempting to list installed plugins when there werent any installed.
How I did it
When given an empty list in the helper function, return empty list.
How to verify it
ape plugins listChecklist