-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: wrap up link fixes [APE-1482] #1711
Conversation
@@ -80,7 +80,7 @@ The CLI tool contains all the Ape commands and the Python SDK contains the class | |||
|
|||
## **Ape Modular Plugin System:** | |||
|
|||
Our [list of plugins](https://www.apeworx.io/#plugins) is the best way to have the most interoperable experience with Web3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is no longer a real link it seems
@@ -18,7 +18,7 @@ This guide is for showcasing utilities that ship with Ape to assist in your CLI | |||
|
|||
## Ape Context Decorator | |||
|
|||
The `@ape_cli_context` gives you access to all the root Ape objects (`accounts`, `networks` etc.), the ape logger, and an `abort` method for stopping execution of your CLI gracefully. | |||
The [@ape_cli_context](../methoddocs/cli.html#ape.cli.options.ape_cli_context) gives you access to all the root Ape objects (`accounts`, `networks` etc.), the ape logger, and an [abort](../methoddocs/cli.html#ape.cli.options.ApeCliContextObject.abort) method for stopping execution of your CLI gracefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were just missed opportunities for links
|
||
Define fixtures for static data used by tests. This data can be accessed by all tests in the suite unless specified otherwise. This could be data as well as helpers of modules which will be passed to all tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part was just wordy and distracting, so i tidied it up
@@ -7,6 +7,11 @@ | |||
|
|||
from ape.types import AddressType | |||
|
|||
# Fix 404 in doc link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is maybe the 404 the original ticket was talking about?
Before, we just got the doc from the package it is from (in the EF), but its links didnt work when in ape's docs
This fixes it!
What I did
The real issue was fixed by #1321
but it was never closed
This completes it by auditing and "fixing" the rest: fixes: #1263
I could find no more bad links after this
How I did it
How to verify it
Checklist