docs: wrap up link fixes [APE-1482] #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Oct 31, 2023
| @@ -80,7 +80,7 @@ The CLI tool contains all the Ape commands and the Python SDK contains the class | |||
|
|
|||
| ## **Ape Modular Plugin System:** | |||
|
|
|||
| Our [list of plugins](https://www.apeworx.io/#plugins) is the best way to have the most interoperable experience with Web3. | |||
There was a problem hiding this comment.
this is no longer a real link it seems
| @@ -18,7 +18,7 @@ This guide is for showcasing utilities that ship with Ape to assist in your CLI | |||
|
|
|||
| ## Ape Context Decorator | |||
|
|
|||
| The `@ape_cli_context` gives you access to all the root Ape objects (`accounts`, `networks` etc.), the ape logger, and an `abort` method for stopping execution of your CLI gracefully. | |||
| The [@ape_cli_context](../methoddocs/cli.html#ape.cli.options.ape_cli_context) gives you access to all the root Ape objects (`accounts`, `networks` etc.), the ape logger, and an [abort](../methoddocs/cli.html#ape.cli.options.ApeCliContextObject.abort) method for stopping execution of your CLI gracefully. | |||
There was a problem hiding this comment.
these were just missed opportunities for links
|
|
||
| Define fixtures for static data used by tests. This data can be accessed by all tests in the suite unless specified otherwise. This could be data as well as helpers of modules which will be passed to all tests. |
There was a problem hiding this comment.
this part was just wordy and distracting, so i tidied it up
fubuloubu
previously approved these changes
Oct 31, 2023
antazoey
commented
Oct 31, 2023
| @@ -7,6 +7,11 @@ | |||
|
|
|||
| from ape.types import AddressType | |||
|
|
|||
| # Fix 404 in doc link. | |||
There was a problem hiding this comment.
This is maybe the 404 the original ticket was talking about?
Before, we just got the doc from the package it is from (in the EF), but its links didnt work when in ape's docs
This fixes it!
fubuloubu
previously approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The real issue was fixed by #1321
but it was never closed
This completes it by auditing and "fixing" the rest: fixes: #1263
I could find no more bad links after this
How I did it
How to verify it
Checklist