Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Python 3.12 support #1994

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Apr 9, 2024

What I did

requires released versions with:

ApeWorX/eth-pydantic-types#8 https://pypi.org/project/eth-pydantic-types/0.1.0/
ApeWorX/ethpm-types#119 https://pypi.org/project/ethpm-types/0.6.9/
ApeWorX/eip712#46 https://pypi.org/project/eip712/0.2.5/
ApeWorX/evm-trace#60 https://pypi.org/project/evm-trace/0.1.3/

How I did it

How to verify it

Checklist

  • All changes are completed
    - [ ] New test cases have been added
    - [ ] Documentation has been updated

@antazoey antazoey mentioned this pull request Apr 9, 2024
3 tasks
fubuloubu
fubuloubu previously approved these changes Apr 9, 2024
@fubuloubu fubuloubu enabled auto-merge (squash) April 9, 2024 22:30
@fubuloubu fubuloubu disabled auto-merge April 9, 2024 22:32
@fubuloubu
Copy link
Member

Blocked by: #1995

@antazoey
Copy link
Member Author

Blocked by: #1995

Unblocked now

@antazoey
Copy link
Member Author

looks like pyevm uses pkg_resources.

@antazoey
Copy link
Member Author

so ya... Pyevm uses pkg_resources up until the 0.9 range. I believe we would have update quite a bit of eth dependencies for this, which some people are argue is breaking and thus we may want to hold off until 0.8. Open to suggestions.

@fubuloubu
Copy link
Member

so ya... Pyevm uses pkg_resources up until the 0.9 range. I believe we would have update quite a bit of eth dependencies for this, which some people are argue is breaking and thus we may want to hold off until 0.8. Open to suggestions.

Would it change how we use eth dependencies to such an extent it would break our own?

V0.8 is not so far away where I'm okay punting to that just to be extra cautious. At least we got our lower level dependencies upgraded already

@antazoey
Copy link
Member Author

Would it change how we use eth dependencies to such an extent it would break our own?

I think not really, but the hexbytes change is rather major. I remember users complaining in the past when I bumped web3.py too early.

@antazoey
Copy link
Member Author

I created an issue because I noticed py-evm does not really claim to be fully Python 3.12 compatible: ethereum/py-evm#2169

@antazoey
Copy link
Member Author

can merge this first: #2014 since separate but necessary

@antazoey
Copy link
Member Author

waiting on an eth-tester / web3.py release and this will be good

fubuloubu
fubuloubu previously approved these changes Apr 20, 2024
fubuloubu
fubuloubu previously approved these changes Apr 23, 2024
@antazoey
Copy link
Member Author

importlib is struggling on python 3.12 because of no distutils. How peculiar.

fubuloubu
fubuloubu previously approved these changes Apr 23, 2024
@NotPeopling2day
Copy link
Contributor

NotPeopling2day commented Apr 24, 2024

So my "fix" for entrypoints fixed the tests for 3.12 but broke all the others :/

Ah! https://docs.python.org/3/library/importlib.metadata.html
Screenshot 2024-04-23 at 9 58 40 PM

Pushed a conditional check but feel free to update if you would rather use the backport

@antazoey antazoey merged commit 6e3b584 into ApeWorX:main Apr 24, 2024
17 checks passed
@antazoey antazoey deleted the feat/python312 branch April 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants