-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Python 3.12 support #1994
Conversation
Blocked by: #1995 |
7c96244
to
689177d
Compare
Unblocked now |
looks like |
so ya... Pyevm uses pkg_resources up until the 0.9 range. I believe we would have update quite a bit of eth dependencies for this, which some people are argue is breaking and thus we may want to hold off until 0.8. Open to suggestions. |
Would it change how we use eth dependencies to such an extent it would break our own? V0.8 is not so far away where I'm okay punting to that just to be extra cautious. At least we got our lower level dependencies upgraded already |
I think not really, but the hexbytes change is rather major. I remember users complaining in the past when I bumped web3.py too early. |
I created an issue because I noticed py-evm does not really claim to be fully Python 3.12 compatible: ethereum/py-evm#2169 |
2e75f6c
to
03f660e
Compare
can merge this first: #2014 since separate but necessary |
waiting on an eth-tester / web3.py release and this will be good |
110ab06
to
48b6712
Compare
importlib is struggling on python 3.12 because of no distutils. How peculiar. |
48b6712
to
830229b
Compare
830229b
to
810debd
Compare
So my "fix" for entrypoints fixed the tests for 3.12 but broke all the others :/ Ah! https://docs.python.org/3/library/importlib.metadata.html Pushed a conditional check but feel free to update if you would rather use the backport |
67b3e90
to
c9cbc9f
Compare
c9cbc9f
to
3b25939
Compare
What I did
requires released versions with:
ApeWorX/eth-pydantic-types#8https://pypi.org/project/eth-pydantic-types/0.1.0/ApeWorX/ethpm-types#119https://pypi.org/project/ethpm-types/0.6.9/ApeWorX/eip712#46https://pypi.org/project/eip712/0.2.5/ApeWorX/evm-trace#60https://pypi.org/project/evm-trace/0.1.3/How I did it
How to verify it
Checklist
- [ ] New test cases have been added- [ ] Documentation has been updated