Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove setuptools dependence #2003

Closed
wants to merge 4 commits into from

Conversation

wakamex
Copy link
Contributor

@wakamex wakamex commented Apr 15, 2024

What I did

spun out from #2000, remove setuptools dependency

How I did it

two ways:

  1. remove dependency caps. recent versions of some dependencies have removed usage of pkg_resources.
  2. for those dependencies that haven't, fork them to remove usage of pkg_resources, and point to that fork.

How to verify it

install with uv then run ape plugins list and see if it errors out complaining about pkg_resources.

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@wakamex
Copy link
Contributor Author

wakamex commented Apr 15, 2024

PRs to remove setuptools dependency from dependencies:
[x] eth-tester ethereum/eth-tester#288
[x] eip712 ApeWorX/eip712#48
[x] evm-trace ApeWorX/evm-trace#62

after this, we can remove forks from setup.py

@wakamex
Copy link
Contributor Author

wakamex commented Apr 17, 2024

PRs are in for all 3 dependencies, but eth-tester hasn't bumped their version, so we'd have to pin a hash if we want to use it right now, or wait for them to bump it.

@wakamex wakamex mentioned this pull request Apr 21, 2024
3 tasks
@wakamex
Copy link
Contributor Author

wakamex commented Apr 22, 2024

eth-tester just put out a new beta which includes the PR to move away from setuptools.
I just updated to it, which also includes updating eth-account to >=0.11.2. will that break anything @antazoey? nevermind, I just noticed it's >=0.11.2 on main now.. rebasing

@wakamex wakamex force-pushed the remove_setuptools_dependency branch from f85e197 to af876ee Compare April 22, 2024 19:03
@wakamex
Copy link
Contributor Author

wakamex commented Apr 22, 2024

so the only change in this PR that isn't merged on main is adding the eth-tester requirement. let me even see if that's still required.

@wakamex
Copy link
Contributor Author

wakamex commented Apr 22, 2024

both uv pip and pip install eth-tester 0.11.0b2, so nothing needs to be done here.

this is due to web3[tester] having the following dependence: "eth-tester[py-evm]>=0.11.0b1,<0.12.0b1", which picks up 0.11.0b2 😀

@wakamex wakamex closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant