fix: issue with kwargs for get_logs using eth-tester #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflicting dependency with eth-abi and eip712, introduced here #2002 |
|
required ApeWorX/eip712#49 i guess |
3 tasks
antazoey
force-pushed
the
fix/web3-eth-tester-logs-kwarg
branch
from
00a2466
to
34c0ab0
Compare
fubuloubu
previously approved these changes
Apr 15, 2024
fubuloubu
previously approved these changes
Apr 15, 2024
antazoey
force-pushed
the
fix/web3-eth-tester-logs-kwarg
branch
from
baac36e
to
8d67872
Compare
fubuloubu
previously approved these changes
Apr 16, 2024
|
Looks like test failure is not detecting scripts anymore |
|
somehow there is a weird package called |
|
yet, |
|
This also happens to me on |
|
Pretty sure i found the culprit: https://github.com/ethereum/py-evm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
somehow the latest web3.py causes intermittent failures with eth-tester get_logs kwargs.
this should take care of it
How I did it
How to verify it
Checklist