test: showing dependencies works in project.extract_manifest()
#2236
Conversation
|
|
||
| assert found, "Failed to find expected deployment URI" | ||
|
|
||
| # Prove that dependencies works. |
There was a problem hiding this comment.
These are all local package dependencies?
There was a problem hiding this comment.
yes, but chatting with The God of Ninjas, I have learned to try stuff with snekmate, so going to experiment there.
There was a problem hiding this comment.
It may be the case we just don't have a good way to share non-local dependencies using EthPM, and so we can just ask for additional dependencies when compiling in a more ape-friendly config format to use in his service
There was a problem hiding this comment.
As long as it's in your config, it should work, it just turns to a URL format.
There was a problem hiding this comment.
But it has to be the URL of an EthPM Manifest (which is not very common)
There was a problem hiding this comment.
Why just be a link to a directory containing the files? That is how it works now, and ape puts them in a manifest
There was a problem hiding this comment.
This isn't really how it's meant to work, which is why EthPM needs to be fundamentally re-thought anyways. Dependencies are best as like links to a zip file, ipfs directory, or other filesystem-like resource that is globally reference-able and contains sources to use (and potentially compiler settings, compiled artifacts, and other reference metadata that may be useful too) so a downstream project can describe its build manifest in full
For the hosted-compiler we can just use a list of ape-compatible dependency objects which we can push into an ape-config to use to compile with
There was a problem hiding this comment.
FWIW, Ape is getting better at deducing settings from a project structure, such as Foundry projects.
So if you have a URL, you can fetch it and ape can do Project(path).extract_manifest()
There was a problem hiding this comment.
snekmate includes absolutely nothing besides contracts in their published PyPI package, which is frustrating. I told them that and they didn't care.
There was a problem hiding this comment.
Technically, a Python wheel is a zip file at some URI on the pypi server
What I did
i heard there was a bug here but not sure what it is, here is a test proving dependencies works in package manifest.
lemme know how to add more conditions to reach a failing state
How I did it
How to verify it
Checklist