Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always serialize block size to int #2324

Merged
merged 5 commits into from
Oct 17, 2024
Merged

fix: always serialize block size to int #2324

merged 5 commits into from
Oct 17, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Oct 17, 2024 •
edited
Loading

What I did

  • handle hex values in block validation for size
  • handle hex values when injected in _size
  • always serialize to int for size

How I did it

field serializer on size to force to be an int even when it is not

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title test: showing block serialization working fix: always serialize block size to int Oct 17, 2024
@antazoey antazoey marked this pull request as ready for review October 17, 2024 16:48
mikeshultz
mikeshultz approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mikeshultz mikeshultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing appears to be working well. LGTM

@antazoey antazoey merged commit 3f2f301 into ApeWorX:main Oct 17, 2024
17 checks passed
@antazoey antazoey deleted the fix/serialize-block branch October 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshultz mikeshultz mikeshultz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @mikeshultz