Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where snapshots lingered on disconnect #2332

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

antazoey
Copy link
Member

What I did

this bug is preventing us from using ape test to test ape.
this may fix other oddities with multi-chain tests and isolation.

How I did it

  • use chain ID when keeping track of snaps
  • when disconnecting, also clear snaps from that cache

probably

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey
Copy link
Member Author

note: feature is even more tested when we merge in with #2327 branch

@antazoey antazoey merged commit c695988 into ApeWorX:main Oct 21, 2024
16 checks passed
@antazoey antazoey deleted the fix/invalidate-snapshots-on-restart branch October 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants