Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use str type with bytes validator #2340

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: use str type with bytes validator #2340

merged 2 commits into from
Oct 25, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Oct 24, 2024 •
edited
Loading

What I did

Allow bytes in TransactionTrace hash

fixes: #2339

How I did it

Use HexStr pydantic type

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey
Copy link
Member Author

Wait to merge until this comment is addressed: #2333 (comment)
If we decided to punt the help to 0.9, I want to revert the last merged commit (and merge it into the help PR) first before proceeding with anything else.

@antazoey antazoey merged commit a24374b into ApeWorX:main Oct 25, 2024
16 checks passed
@antazoey antazoey deleted the fix/trace-hash-bytes branch October 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction trace does not handle HexBytes txn_hash
2 participants
@antazoey @fubuloubu