Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue running tests when mainnet is default network and specifying a different network #2343

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Oct 26, 2024

What I did

fixes: #2342

How I did it

Move the config error to a later point, check for the --network flag.

How to verify it

cfg:

ethereum:
  default_network: mainnet
  mainnet:
    default_provider: node
  mainnet_fork:
    default_provider: foundry

then run

ape test

should fail

and run

ape test --network ethereum:local:test

should not fail

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey merged commit fee84bb into ApeWorX:main Oct 26, 2024
18 checks passed
@antazoey antazoey deleted the fix/mainnet-network-tests-bug branch October 26, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants