Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: callable trace bug when estimating gas on revert-tx with no fail message #2344

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

antazoey
Copy link
Member

What I did

fixes: #2341

How I did it

  • call callable when callable

How to verify it

gas estimation fail + revert no message

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title Fix/revert message gas estimate fix fix: callable trace bug when estimating gas on revert-tx with no fail message Oct 26, 2024
@antazoey antazoey merged commit 54dcc57 into ApeWorX:main Oct 26, 2024
16 checks passed
@antazoey antazoey deleted the fix/revert-message-gas-estimate-fix branch October 26, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling revert during gas estimation
2 participants