add michales fix and tests

_package/tests/unit_tests/filesystem_pyt.py

@@ -46,4 +46,11 @@ def test_temp_filename(self):
         extension = os.path.splitext(f)[1]
         self.assertEqual('.suffix_test', extension)
 
+        # With XMS_PYTHON_APP_TEMP_DIRECTORY environment variable
+        d = tempfile.mkdtemp()
+        os.environ['XMS_PYTHON_APP_TEMP_DIRECTORY'] = d
+        f = filesystem.temp_filename()
+        os.environ.pop('XMS_PYTHON_APP_TEMP_DIRECTORY')
+        self.assertEqual(os.path.normpath(os.path.dirname(f)), os.path.normpath(d))
+
         shutil.rmtree(d)

_package/xms/core/__init__.py

@@ -4,4 +4,4 @@
 from . import filesystem  # NOQA: F401
 from . import misc  # NOQA: F401
 
-__version__ = '3.2.1
+__version__ = '3.2.1'

_package/xms/core/filesystem/filesystem.py

@@ -182,7 +182,7 @@ def file_prefix(filepath):
 
 
 def temp_filename(dir='', suffix=''):
-    """Returns a temporary filename.
+    """Returns a temporary filename, in the XMS temp directory by default.
 
     Args:
         dir: If provided, filename will be in the directory. Otherwise it will be in the
@@ -191,12 +191,15 @@ def temp_filename(dir='', suffix=''):
 
     Returns:
         See description.
-
     """
     if dir:  # If we call the next line with dir == '', it seems to use the working directory.
         file = tempfile.NamedTemporaryFile(mode='wt', suffix=suffix, dir=dir, delete=True)
     else:
-        file = tempfile.NamedTemporaryFile(mode='wt', suffix=suffix, delete=True)
+        xms_temp = os.environ.get('XMS_PYTHON_APP_TEMP_DIRECTORY', 'unknown')
+        if xms_temp != 'unknown':
+            file = tempfile.NamedTemporaryFile(mode='wt', suffix=suffix, dir=xms_temp, delete=True)
+        else:
+            file = tempfile.NamedTemporaryFile(mode='wt', suffix=suffix, delete=True)
 
     filename = file.name
     file.close()