Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UpgradeAndEnableFastConfirmAction action #305

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: UpgradeAndEnableFastConfirmAction action #305

wants to merge 4 commits into from

Conversation

gzeoneth
Copy link
Collaborator

@gzeoneth gzeoneth commented Aug 6, 2024 •
edited
Loading

  • Upgrade rollup logics
  • Setup AnyTrustFastConfirmer
  • Set AnyTrustFastConfirmer as validator
  • Set minimum assertion period

@godzillaba
Copy link
Collaborator

verified bytecode of rollup logics

godzillaba
godzillaba requested changes Aug 9, 2024
View reviewed changes
src/gov-action-contracts/AIPs/EnableFastConfirm/NovaUpgradeAndEnableFastConfirmAction.sol
Comment on lines +13 to +14
0x0000000000000000000000000000000000000000, // TODO: anyTrustFastConfirmer
1 // TODO: newMinimumAssertionPeriod in blocks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know we're in draft right now and these are marked with comments but just adding a blocking review so we definitely don't forget to set these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godzillaba godzillaba godzillaba requested changes

@gvladika gvladika Awaiting requested review from gvladika

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzeoneth @godzillaba