Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates timelock delay #306

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Updates timelock delay #306

wants to merge 18 commits into from
+52 −2

Conversation

yahgwai
Copy link
Collaborator

@yahgwai yahgwai commented Aug 7, 2024 •
edited
Loading

@yahgwai yahgwai marked this pull request as ready for review August 7, 2024 18:10
godzillaba
godzillaba approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@godzillaba godzillaba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could set the registry as a constant though

src/gov-action-contracts/AIPs/CoreGovTimelockUpdateDelay.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godzillaba godzillaba godzillaba approved these changes

@gzeoneth gzeoneth gzeoneth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yahgwai @godzillaba @gzeoneth