fix: bug finding on ui/ux and docker built image issue #81
+144
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
zulkhair
changed the title
zulkhair
force-pushed
the
daim/fix_bug_finding_on_ui_ux_and_docker_built_image_issue
branch
2 times, most recently
from
e4eb53c
to
338cc4b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## daim/fix_sentry_version #81 +/- ##
===========================================================
+ Coverage 45.72% 47.71% +1.98%
===========================================================
Files 56 56
Lines 3427 3521 +94
===========================================================
+ Hits 1567 1680 +113
+ Misses 1655 1627 -28
- Partials 205 214 +9 ☔ View full report in Codecov by Sentry. |
rmrt1n
approved these changes
Oct 17, 2024
zulkhair
force-pushed
the
daim/fix_bug_finding_on_ui_ux_and_docker_built_image_issue
branch
2 times, most recently
from
5b3aaf4
to
7cc3ea5
Compare
zulkhair
force-pushed
the
daim/fix_sentry_version
branch
from
0ded692
to
e1adc44
Compare
zulkhair
force-pushed
the
daim/fix_bug_finding_on_ui_ux_and_docker_built_image_issue
branch
from
7cc3ea5
to
433d967
Compare
Merge activity
|
Closes: WORLD-1196, WORLD-1205, WORLD-1206, WORLD-1207 ## Overview Fix bug findings on world cli v1.3.1-Beta4 ## Brief Changelog - Fix docker image not builded without exec `world cardinal purge` firs. it's because container need to be removed first so that docker create new container with new image - Remove red and yellow color for container name - Fix `--log-level` flag not functioned properly, it's because the envar is not passed to the docker env. - Move `-v` and `-c` from global flags to only flag in 3rd subcommand - Add help for `--log-level` value (ex : info, debug, etc) ## Testing and Verifying - Manually tested - Still covered by unit test
zulkhair
force-pushed
the
daim/fix_sentry_version
branch
from
e1adc44
to
acd9f95
Compare
zulkhair
force-pushed
the
daim/fix_bug_finding_on_ui_ux_and_docker_built_image_issue
branch
from
433d967
to
84f5fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: WORLD-1196, WORLD-1205, WORLD-1206, WORLD-1207
Overview
Fix bug findings on world cli v1.3.1-Beta4
Brief Changelog
world cardinal purgefirs. it's because container need to be removed first so that docker create new container with new image--log-levelflag not functioned properly, it's because the envar is not passed to the docker env.-vand-cfrom global flags to only flag in 3rd subcommand--log-levelvalue (ex : info, debug, etc)Testing and Verifying