Skip to content

fix(ui): show inline rename text in session sidebar - #345

Merged
Ark0N merged 1 commit into
Ark0N:masterfrom
fibr:fix/sidebar-inline-rename
Aug 27, 2026
Merged

fix(ui): show inline rename text in session sidebar#345
Ark0N merged 1 commit into
Ark0N:masterfrom
fibr:fix/sidebar-inline-rename

Conversation

@fibr

@fibr fibr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apply the live rename editor layout to the session sidebar as well as the vertical tab rail
  • prevent the sidebar tab label's ellipsis paint from hiding the focused input
  • add a Chromium regression test covering visible, focused sidebar typing

Verification

  • npm run test:browser -- test/inline-rename.test.ts (14 passed)
  • npm test (316 files passed, 6,185 tests passed)
  • npm run typecheck
  • npm run lint
  • npm run check:frontend-syntax
  • npm run check:public-assets
  • npm run format:check
  • manually verified the rich sidebar in Chromium: typed text and caret render in the focused editor

@fibr

fibr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Hi, just a small enhancement to the sidebar mode -- i can't see what i'm typing in renaming sessions in the sidebar and this should fix it. Hope it can be taken in :-)

@Ark0N
Ark0N merged commit da085f5 into Ark0N:master Aug 27, 2026
@Ark0N

Ark0N commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Thanks, merged.

Verified rather than taken on trust: with your CSS reverted to master the new test fails with expected 'hidden' to be 'visible', and with it applied the file is 14/14 green (npm run test:browser -- test/inline-rename.test.ts). Good instinct pinning the painted overflow and the input's measured width rather than just the class name, that is the half a class-only assertion would have missed.

One note for whoever touches this next, no action needed here: CLAUDE.md asks rail/sidebar twins to be comma-grouped rather than :is(), because an :is() list takes its most specific argument. It is harmless in this case since both arms are (0,2,1), so the rule lands at (0,5,1) either way, which is what clears the (0,3,1) sidebar clamp further down the file. It would only start to matter if a third arm with a different weight ever joined the list.

Ark0N pushed a commit that referenced this pull request Aug 27, 2026
Codex plan usage in the header chip (#346), a visible inline rename in
the session sidebar (#345), and the install.sh Tailscale re-run fix plus
the README network-access prompt description.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants