Add basic socket activation support #717
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Eric,
I wrote a proof-of-concept implementation to support systemd socket activation. The motivation is is that I use an Nginx reverse proxy to host Moonraker and Fluidd under the same CORS domain, and I also want Nginx to handle TLS so I can easily integrate certbot.
There are some other advantages with socket activation:
This implementation is only a quick hack, least resistance path towards my use case. I would like to chat with you before jumping into a full implementation. Specifically there are a few issues I want to hear your opinion about:
Server.get_host_info()
, HTTPLocation
header and generally other things that need to be aware of the server's published address?