Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-block migrator #1322

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Multi-block migrator #1322

merged 9 commits into from
Aug 27, 2024

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Aug 9, 2024

Pull Request Summary

Add multi-block migration pallet.
Re-structure migration definition.
Service weight is set to 50% because only inherent extrinsic are applied during migrations. Almost entire block is dedicated to migrations.

@ermalkaleci ermalkaleci added runtime This PR/Issue is related to the topic “runtime”. shiden related to shiden runtime astar Related to Astar shibuya related to shibuya labels Aug 9, 2024
@ermalkaleci ermalkaleci marked this pull request as ready for review August 9, 2024 12:12
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only real concern is the question about EnterSafeModeOnFailedMigration.

runtime/astar/src/lib.rs Show resolved Hide resolved
runtime/astar/src/lib.rs Outdated Show resolved Hide resolved
runtime/astar/src/lib.rs Outdated Show resolved Hide resolved
@ermalkaleci ermalkaleci changed the title Multi-block migrator WIP: Multi-block migrator Aug 9, 2024
@ermalkaleci ermalkaleci changed the title WIP: Multi-block migrator Multi-block migrator Aug 14, 2024
@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test astar

@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test shiden

@ermalkaleci
Copy link
Contributor Author

/runtime-upgrade-test shibuya

Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10384640871.
Please wait for a while.
Runtime: astar
Branch: feat/add-pallet-migrations
SHA: 1c909e8

Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10384645075.
Please wait for a while.
Runtime: shiden
Branch: feat/add-pallet-migrations
SHA: 1c909e8

Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10384646602.
Please wait for a while.
Runtime: shibuya
Branch: feat/add-pallet-migrations
SHA: 1c909e8

Copy link

Runtime upgrade test finished:

yarn run v1.22.22
$ RUNTIME=astar yarn test tests/runtime-upgrade.test.ts
$ LOG_LEVEL=error vitest --silent --no-color tests/runtime-upgrade.test.ts

RUN v2.0.5 /home/runner/work/Astar/Astar/tests/e2e

✓ tests/runtime-upgrade.test.ts (1 test) 76407ms

Test Files 1 passed (1)
Tests 1 passed (1)
Start at 09:17:05
Duration 81.41s (transform 31ms, setup 0ms, collect 4.76s, tests 76.41s, environment 0ms, prepare 57ms)

Done in 81.91s.

Copy link

Runtime upgrade test finished:

yarn run v1.22.22
$ RUNTIME=shiden yarn test tests/runtime-upgrade.test.ts
$ LOG_LEVEL=error vitest --silent --no-color tests/runtime-upgrade.test.ts

RUN v2.0.5 /home/runner/work/Astar/Astar/tests/e2e

✓ tests/runtime-upgrade.test.ts (1 test) 263066ms

Test Files 1 passed (1)
Tests 1 passed (1)
Start at 09:17:32
Duration 268.69s (transform 39ms, setup 0ms, collect 5.37s, tests 263.07s, environment 0ms, prepare 65ms)

Done in 269.20s.

Copy link

Runtime upgrade test finished:

yarn run v1.22.22
$ RUNTIME=shibuya yarn test tests/runtime-upgrade.test.ts
$ LOG_LEVEL=error vitest --silent --no-color tests/runtime-upgrade.test.ts

RUN v2.0.5 /home/runner/work/Astar/Astar/tests/e2e

✓ tests/runtime-upgrade.test.ts (1 test) 255889ms

Test Files 1 passed (1)
Tests 1 passed (1)
Start at 09:17:47
Duration 262.26s (transform 29ms, setup 0ms, collect 6.13s, tests 255.89s, environment 0ms, prepare 57ms)

Done in 262.77s.

ipapandinas
ipapandinas previously approved these changes Aug 23, 2024
Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/astar/src/lib.rs Outdated Show resolved Hide resolved
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
pallets/ethereum-checked/src 74% 0%
primitives/src 59% 0%
pallets/dapp-staking-v3/src 83% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/assets-erc20/src 78% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/price-aggregator/src 82% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/unified-accounts/src 100% 0%
pallets/unified-accounts/src 86% 0%
pallets/inflation/src 93% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/pallet-assets/src 56% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
precompiles/xcm/src 71% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/sr25519/src 64% 0%
pallets/collator-selection/src 92% 0%
primitives/src/xcm 65% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/collective-proxy/src 86% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/static-price-provider/src 85% 0%
pallets/xc-asset-config/src 50% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
Summary 79% (3649 / 4608) 0% (0 / 0)

Minimum allowed line rate is 50%

@ermalkaleci ermalkaleci merged commit d2714e5 into master Aug 27, 2024
9 checks passed
@ermalkaleci ermalkaleci deleted the feat/add-pallet-migrations branch August 27, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants