Skip to content

Make TimeoutsHolder.start idempotent #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperxpro merged 1 commit into from
Aug 26, 2026
Merged

Make TimeoutsHolder.start idempotent #2319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions client/src/main/java/org/asynchttpclient/netty/timeout/TimeoutsHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public class TimeoutsHolder {
private static final Logger LOGGER = LoggerFactory.getLogger(TimeoutsHolder.class);

private final AtomicBoolean cancelled = new AtomicBoolean();
private final AtomicBoolean started = new AtomicBoolean();
private final Timer nettyTimer;
private volatile @Nullable EventExecutor eventExecutor;
private final NettyRequestSender requestSender;
Expand Down Expand Up @@ -105,8 +106,14 @@ public TimeoutsHolder(Timer nettyTimer, @Nullable EventExecutor eventExecutor, N
* <p>
* Called by {@link org.asynchttpclient.netty.NettyResponseFuture#setTimeoutsHolder}, so that installing a
* holder is what arms it and neither can be done without the other.
* <p>
* Only the first call arms. A second would overwrite the first handle, leaving an entry nobody can
* cancel to sit in its scheduler until the full deadline, pinning the task, the future and the channel.
*/
public void start() {
if (!started.compareAndSet(false, true)) {
return;
}
if (requestTimeoutTask != null) {
// The configured duration rather than the remaining time: this runs within microseconds of the
// constructor, and reading the clock again would only expose the deadline to a step between the two.
Expand Down
Loading