Premium Analytics: group the routes jest suites - #51467
Open
chihsuan wants to merge 1 commit into
Open
Conversation
Group the 31 routes suites that already declare an identical mock signature, into 4 group files. Grouped suite count drops from 231 to 204.
chihsuan
marked this pull request as ready for review
August 21, 2026 07:45
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
routes/suites that already declare an identical mock signature, into 4 group files (26 with no mocks, 5 sharing the@wordpress/routemock fromtests/js/route-test-utils).Stacked on #51464, which moved the groups out of
widgets/so they can cover any area. Together the two take the package from 267 grouped suites to 204.Local wall-clock is not quotable this round — the machine's available cores moved between runs, so the paired comparison broke down. The controlled measurement that motivated this: 8 representative
routes/config and hook suites take 6.88s run separately and 2.36s as one group (--runInBand, same tree, interleaved).Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Tests only — no product code changes.
pnpm run testinprojects/packages/premium-analytics(grouped): 204 suites, 2390 tests, all passing.PA_NO_GROUPS=1 pnpm run test(ungrouped fallback, which CI never exercises): 294 suites, the same 2390 tests. A mismatch here would mean a suite is running twice or not at all.Unrelated, but worth flagging: a jest worker died with
SIGSEGVon 3 of ~10 local full runs, in both the grouped and ungrouped modes and on trunk as well. Pre-existing, and likely the same memory pressure that CI hits running 12 jest workers on 4 vCPUs.