Skip to content

Premium Analytics: group the routes jest suites - #51467

Open
chihsuan wants to merge 1 commit into
change/pa-group-widgets-toolkit-suitesfrom
change/pa-group-routes-suites
Open

Premium Analytics: group the routes jest suites#51467
chihsuan wants to merge 1 commit into
change/pa-group-widgets-toolkit-suitesfrom
change/pa-group-routes-suites

Conversation

@chihsuan

Copy link
Copy Markdown
Member

Proposed changes

  • Group the 31 routes/ suites that already declare an identical mock signature, into 4 group files (26 with no mocks, 5 sharing the @wordpress/route mock from tests/js/route-test-utils).
  • Grouped suite count: 231 → 204.

Stacked on #51464, which moved the groups out of widgets/ so they can cover any area. Together the two take the package from 267 grouped suites to 204.

Local wall-clock is not quotable this round — the machine's available cores moved between runs, so the paired comparison broke down. The controlled measurement that motivated this: 8 representative routes/ config and hook suites take 6.88s run separately and 2.36s as one group (--runInBand, same tree, interleaved).

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Tests only — no product code changes.

  • pnpm run test in projects/packages/premium-analytics (grouped): 204 suites, 2390 tests, all passing.
  • PA_NO_GROUPS=1 pnpm run test (ungrouped fallback, which CI never exercises): 294 suites, the same 2390 tests. A mismatch here would mean a suite is running twice or not at all.

Unrelated, but worth flagging: a jest worker died with SIGSEGV on 3 of ~10 local full runs, in both the grouped and ungrouped modes and on trunk as well. Pre-existing, and likely the same memory pressure that CI hits running 12 jest workers on 4 vCPUs.

Group the 31 routes suites that already declare an identical mock
signature, into 4 group files.

Grouped suite count drops from 231 to 204.
@chihsuan chihsuan self-assigned this Aug 21, 2026
@chihsuan
chihsuan marked this pull request as ready for review August 21, 2026 07:45
@chihsuan
chihsuan requested a review from a team as a code owner August 21, 2026 07:45
@chihsuan chihsuan added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the change/pa-group-routes-suites branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack change/pa-group-routes-suites
bin/jetpack-downloader test jetpack-mu-wpcom-plugin change/pa-group-routes-suites

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

No summary data is available for parent commit 5673f34, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 5673f34 is available.

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant