Fix env.example Default Values #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up commit to use an Azure unique prefix for the Azure resources that ARO-RP is using instead of always fetching the USER. When AZURE_PREFIX env var is not set, then use the USER env var
razo7
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Don't override existed LOCATION env var when it is already set, and 'westeurope' as the default value
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
razo7
changed the title
SudoBrendan
approved these changes
Sep 16, 2024
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rhamitarora
approved these changes
Sep 17, 2024
kimorris27
approved these changes
Sep 17, 2024
edisonLcardenas
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Set Azure prefix and USER as optional at env.example Follow up commit to use an Azure unique prefix for the Azure resources that ARO-RP is using instead of always fetching the USER. When AZURE_PREFIX env var is not set, then use the USER env var * Use westeurope as default location Don't override existed LOCATION env var when it is already set, and 'westeurope' as the default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up commit to #3681 when AZURE_PREFIX env var was suggested and fix due to #3593 changes
Which issue this PR addresses:
It complicates testing #3815 when the USER is not set.
What this PR does / why we need it:
westeurope.Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?