[ARO-1885] Implement OperatorFlagsMergeStrategy #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
added
enhancement
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
SrinivasAtmakuri
approved these changes
Oct 21, 2024
edisonLcardenas
approved these changes
Oct 21, 2024
rhamitarora
reviewed
Oct 22, 2024
| tests := []struct { | ||
| name string | ||
| oc *api.OpenShiftCluster | ||
| wantOc *api.OpenShiftCluster |
There was a problem hiding this comment.
The variable wantOc is declared, but its usage is not shown anywhere.
bitoku
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-1885
What this PR does / why we need it:
Allows us to 'reset' feature flags to their defaults by providing ones that we wish to layer on top of said defaults.
Broken out of #3571 because I needed it for some tests. Based off work by @SrinivasAtmakuri in another PR.
Test plan for issue:
Unit tests
Is there any documentation that needs to be updated for this PR?
SOPs for operator flag working might be needed?
How do you know this will function as expected in production?
Unit tests, plus it won't do anything in production unless we make it do so