Fix updating the Azure API Management #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aform was indicating a `forced replacement` due to a calculation of the resource group ID. Passing it as a variable from the main module helps Terraform no to force a replacement, and updating APIs and policies without issue. Also, updated the dependency on the policy item to the tenant ID named value.
rliberoff
requested review from
heblasco,
rag2111,
aniturza,
monicacalleja and
cmendible
as code owners
rliberoff
changed the title
cmendible
requested changes
Jun 10, 2024
infra/modules/apim/main.tf
Outdated
| @@ -172,7 +168,7 @@ resource "azurerm_api_management_api_policy" "policy" { | |||
| </on-error> | |||
| </policies> | |||
| XML | |||
| depends_on = [azurerm_api_management_backend.openai, azapi_resource.apim_backend_pool] | |||
| depends_on = [azurerm_api_management_named_value.tenant_id] | |||
There was a problem hiding this comment.
Please remove this dependency the named value resource depends on the apim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on any update, Terraform was indicating a
forced replacementdue to a calculation of the resource group ID. Passing it as a variable from the main module helps Terraform no to force a replacement, and updating APIs and policies without issue.Also, updated the dependency on the policy item to the tenant ID named value.