Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage - correctly handle root level discriminator #109

Merged
merged 9 commits into from
Sep 11, 2024
Merged

coverage - correctly handle root level discriminator #109

merged 9 commits into from
Sep 11, 2024

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Sep 11, 2024

No description provided.

ms-henglu
ms-henglu requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM! I only have one comment on the test, please check.

coverage/coverage_test.go Show resolved Hide resolved
@teowa teowa force-pushed the handle_root_level_discriminator branch from ffd1d0a to a88e151 Compare September 11, 2024 05:43
@ms-henglu ms-henglu merged commit f137f57 into Azure:main Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms-henglu ms-henglu ms-henglu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teowa @ms-henglu