Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a decision about examples from mock values and real values #5011

Open
Tracked by #4805
ArcturusZhang opened this issue Aug 22, 2024 · 0 comments
Open
Tracked by #4805

Make a decision about examples from mock values and real values #5011

ArcturusZhang opened this issue Aug 22, 2024 · 0 comments
Labels

Comments

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Aug 22, 2024

Since we have the ability of generating examples from real example values (reading from the json files examples in the spec repo), we need to decide how we deal with those operations without a real example.

When there is an examples-dir configured, for those operations that do not have an example file, should we continue to generate examples with mock values?

In the implementation in this PR, we do not. I think it might be misleading because the examples from mock values look exactly the same as the ones from real values - there is no distinguishable flags or anything to mark those from mock values. Therefore I think it is a bad idea of mixing them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant