Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt examples from TCGC #4959

Merged

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Aug 5, 2024

Fixes #4980
Fixes #5006

Description

To adopt the example information from TCGC, we are taking the following steps, and this PR is the second step (first step is done in the typespec repo PR).

  1. Update the emitter so that the emitter could spit out the examples from TCGC.
  2. Refine our code in DPG so that the sample generator made for DPG is able to write out those examples, as if they are the mock examples.
  3. Refine our code in MPG so that the examples for mgmt could be written when the input is typespec.
  4. Possible follow ups: use the responses, now the responses in examples are not used.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang merged commit 9dae8bf into Azure:feature/v3 Aug 22, 2024
8 checks passed
@ArcturusZhang ArcturusZhang deleted the adopt-example-values-from-tcgc branch August 22, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable our DPG sample generator to take the example data from TCGC Adopt TCGC example information
4 participants