Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade compiler version and fix issues #4967

Merged
merged 7 commits into from
May 24, 2024
Merged

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented May 17, 2024

  1. Upgrade compiler version to 0.56
  2. TrackedResourceBase => Foundations.TrackedResource (same as others: XXXResourceBase => Foundations.XXXResource)
  3. Azure.ResourceManager.ManagedServiceIdentity => Azure.ResourceManager.ManagedServiceIdentityProperty (same as others Azure.ResourceManager.XXX=> Azure.ResourceManager.XXXProperty)
  4. extends Record<XXX> => ...Record<XXX>
  5. name: string in resource => ResourceNameParameter template
  6. @parameterVisibility("read") => @parameterVisibility
  7. TrackedResource => Azure.ResourceManager.TrackedResource
  8. Add suppressions of below syntax to brown field services
  • ArmResourceDeleteSync
  • ArmResourceDeleteAsync
  • property has record type-

@tadelesh
Copy link
Member

can we remove using Azure.ResourceManager.Foundations; and use the explicit import when necessary?

@pshao25 pshao25 merged commit 961b09d into Azure:main May 24, 2024
10 checks passed
@pshao25 pshao25 deleted the upgrade56 branch May 24, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants