Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AZConnectedKubernetes fixes #26379

Draft
wants to merge 38 commits into
base: generation
Choose a base branch
from

Conversation

xw-zhang24
Copy link
Member

@xw-zhang24 xw-zhang24 commented Oct 17, 2024

Description

Bug fixes and improvements for AzConnectedKubernetes module:

  • Add disable flag for WIF feature in Set- command to improve customer experience
  • Resolve syntax issue when running command in Powershell 5.1
  • Parse and use value from InputObject. Set- command will perform a full replacement.
  • Add more examples and improve description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

xw-zhang24 and others added 30 commits September 30, 2024 11:38
Rework code for Powershell 5.1 compatibility.
Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
❌Az.ConnectedKubernetes
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Set-AzConnectedKubernetes 2 1 Unassigned_Variable Set-AzConnectedKubernetes -GatewayResourceId $gatewayResourceId is a null-valued parameter value. -GatewayResourceId Assign value for $gatewayResourceId.
⚠️ Set-AzConnectedKubernetes 3 2 Unassigned_Variable Get-AzConnectedKubernetes -SubscriptionId $subscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $subscriptionId.
⚠️ Set-AzConnectedKubernetes 4 2 Unassigned_Variable Get-AzConnectedKubernetes -SubscriptionId $subscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $subscriptionId.
⚠️ Set-AzConnectedKubernetes 5 2 Unassigned_Variable Get-AzConnectedKubernetes -SubscriptionId $subscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $subscriptionId.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedKubernetes. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
❌Test
❌ - Linux
❌ - MacOS
❌PowerShell Core - Windows

@xw-zhang24 xw-zhang24 changed the title [WIF] AZConnectedKubernetes fixes [WIP] AZConnectedKubernetes fixes Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant