Patch Basic Detection for RLC #9209
Conversation
| - Added Interface ClusterGetOld | ||
| - Added Type Alias typesAdd | ||
| - Added function funcAdd | ||
| - Added function overload "export function isUnexpected(response: C | E): response is C;" |
There was a problem hiding this comment.
I feel like this might be an internal implementation detail. Not sure we want to generate changelog for this?
| - Operation in "Routes" has a new signature for path: "change_para_type" | ||
| - Type of parameter a of interface ClustersGet is changed from number to string | ||
| - Removed function funcRemove | ||
| - Function funcReturnType has a new signature |
There was a problem hiding this comment.
I wonder if we could show what the signature was like before and after? how the changelog would look like?
| - Function funcParameterType has a new signature | ||
| - Removed function overload 'export function isUnexpected(response: C | D): response is A;' | ||
| - Removed Type Alias typesRemove | ||
| - Type alias "typesChange" has been changed` |
There was a problem hiding this comment.
Also what's the type alias be like before and after?
| // check required -> optional | ||
| const isOptional = (node: Node) => node.getSymbolOrThrow().isOptional(); | ||
| const incompatibleOptional = isOptional(target) && !isOptional(source); | ||
| if (incompatibleOptional) breakingReasons |= DiffReasons.RequiredToOptional; |
There was a problem hiding this comment.
Can we differentiate if it's request or response? I think if it's request, changing from required to optional would be a non-breaking.
| } | ||
|
|
||
| // TODO: not support for overloads | ||
| function findParameterBreakingChanges(sourceMethod: Symbol, targetMethod: Symbol): DiffPair[] { |
There was a problem hiding this comment.
I wonder why I see the changelog for isUnexpected helper overloads change if it's not supported yet?
| changelog.removedTypeAlias.push({ line: 'Removed Type Alias ' + name, oldName: name }); | ||
| return; | ||
| } | ||
| // ignore type change, handle in a simple way for now |
There was a problem hiding this comment.
I've also seen the type alias change changelog item, I think?
| @@ -1,4 +1,5 @@ | |||
| export enum SDKType { | |||
| None = 'None', | |||
There was a problem hiding this comment.
is there a real case when we get a None type for SDK?
|
|
||
| export function isSameSignature(left: Signature, right: Signature): boolean { | ||
| if (left.getTypeParameters().length !== right.getTypeParameters().length) return false; | ||
| if (left.getParameters().length !== right.getParameters().length) return false; |
There was a problem hiding this comment.
Just curious, what is getTypeParameters and its difference between getParameters?
Features
Routesin RLCIsUnexpectedFixes
export type A = "X" | "Y"->export type A ="X" | "y"cannot be detectedRouteschanges cannot be detectedNotes
findBreakingReasonsfunction indeclaration-diff.tsfile may be inaccurate. Except for this, the PR is ready for review