Skip to content

Commit

Permalink
Clusterrole and webhook update
Browse files Browse the repository at this point in the history
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
  • Loading branch information
Bangqi Zhu committed Oct 9, 2024
1 parent f613bb4 commit cf603bc
Showing 1 changed file with 36 additions and 0 deletions.
36 changes: 36 additions & 0 deletions api/v1alpha1/ragenging_validation.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

package v1alpha1

import (
"context"
"fmt"

admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
"k8s.io/klog/v2"
"knative.dev/pkg/apis"
)

func (w *RAGEngine) SupportedVerbs() []admissionregistrationv1.OperationType {

Check failure on line 15 in api/v1alpha1/ragenging_validation.go

View workflow job for this annotation

GitHub Actions / build

method RAGEngine.SupportedVerbs already declared at api/v1alpha1/ragengine_validation.go:15:21

Check failure on line 15 in api/v1alpha1/ragenging_validation.go

View workflow job for this annotation

GitHub Actions / unit-tests

method RAGEngine.SupportedVerbs already declared at api/v1alpha1/ragengine_validation.go:15:21
return []admissionregistrationv1.OperationType{
admissionregistrationv1.Create,
admissionregistrationv1.Update,
}
}

func (w *RAGEngine) Validate(ctx context.Context) (errs *apis.FieldError) {

Check failure on line 22 in api/v1alpha1/ragenging_validation.go

View workflow job for this annotation

GitHub Actions / build

method RAGEngine.Validate already declared at api/v1alpha1/ragengine_validation.go:22:21

Check failure on line 22 in api/v1alpha1/ragenging_validation.go

View workflow job for this annotation

GitHub Actions / unit-tests

method RAGEngine.Validate already declared at api/v1alpha1/ragengine_validation.go:22:21
base := apis.GetBaseline(ctx)
if base == nil {
klog.InfoS("Validate creation", "ragengine", fmt.Sprintf("%s/%s", w.Namespace, w.Name))
errs = errs.Also(w.validateCreate().ViaField("spec"))
}
return errs
}

func (w *RAGEngine) validateCreate() (errs *apis.FieldError) {

Check failure on line 31 in api/v1alpha1/ragenging_validation.go

View workflow job for this annotation

GitHub Actions / build

method RAGEngine.validateCreate already declared at api/v1alpha1/ragengine_validation.go:31:21

Check failure on line 31 in api/v1alpha1/ragenging_validation.go

View workflow job for this annotation

GitHub Actions / unit-tests

method RAGEngine.validateCreate already declared at api/v1alpha1/ragengine_validation.go:31:21
if w.Spec.InferenceService == nil {
errs = errs.Also(apis.ErrGeneric("InferenceService must be specified, not neither", ""))
}
return errs
}

0 comments on commit cf603bc

Please sign in to comment.