Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refact updateStatusConditionIfNotMatch for both RAG and workspace #626

Merged
merged 1 commit into from
Oct 14, 2024
Merged

feat: refact updateStatusConditionIfNotMatch for both RAG and workspace #626

merged 1 commit into from
Oct 14, 2024

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:
refact updateStatusConditionIfNotMatch for both RAG and workspace

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

refact updateStatusConditionIfNotMatch for both RAG and workspace
ec01a67 
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel force-pushed the refact_updateStatusConditionIfNotMatch branch from 637f321 to ec01a67 Compare October 14, 2024 04:13
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.43678% with 64 lines in your changes missing coverage. Please review.

Project coverage is 54.49%. Comparing base (5c30038) to head (ec01a67).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/workspace_controller.go 17.94% 57 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   58.18%   54.49%   -3.69%     
==========================================
  Files          30       34       +4     
  Lines        2987     3257     +270     
==========================================
+ Hits         1738     1775      +37     
- Misses       1149     1376     +227     
- Partials      100      106       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bangqipropel bangqipropel merged commit 152e683 into main Oct 14, 2024
6 of 8 checks passed
@bangqipropel bangqipropel deleted the refact_updateStatusConditionIfNotMatch branch October 14, 2024 20:00
bangqipropel pushed a commit that referenced this pull request Oct 17, 2024
Revert "feat: refact updateStatusConditionIfNotMatch for both RAG and…
65382b1 
… workspace (#626)"

This reverts commit 152e683.

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaansehgal99 ishaansehgal99 ishaansehgal99 approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bangqipropel @ishaansehgal99