Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/april #328

Open
wants to merge 125 commits into
base: releases/v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
125 commits
Select commit Hold shift + click to select a range
8d236f5
Remove publish profile from logs (#18)
suaggar Feb 18, 2020
4c81109
Fix typo in action.yml
asranja Feb 26, 2020
dce00f3
Merge pull request #21 from Azure/users/asranja/fixtypo
asranja Feb 26, 2020
318d06d
Update README.md
N-Usha Feb 26, 2020
d3033ba
Update README.md
N-Usha Feb 26, 2020
168fa11
Update README.md
N-Usha Feb 26, 2020
164268c
Remove duplicate error messages (#23)
suaggar Feb 27, 2020
c1b272b
Update README.md
N-Usha Mar 26, 2020
c1ac157
Added L0 tests and yml workflow
eaarora-ms Mar 27, 2020
71af002
Workflow file added
eaarora-ms Mar 27, 2020
38ad8e8
Merge pull request #27 from Azure/addL0Tests
eaarora-ms Mar 30, 2020
9ad85fd
Login&sample workflow
harshitha1112 Apr 22, 2020
afd9651
Sampleworkflow
harshitha1112 Apr 22, 2020
97d0b5b
Cloudshell quickstart
harshitha1112 Apr 22, 2020
6044bc6
word correction
harshitha1112 Apr 22, 2020
0351635
alignment
harshitha1112 Apr 22, 2020
418953d
"create webapp in Azure using app service"
harshitha1112 May 24, 2020
28ffdfe
Merge pull request #31 from Harshu-org/master
N-Usha May 28, 2020
20000ad
Publish prof container master (#35)
aksm-ms Jun 27, 2020
c280a95
Documentation updates for publish profile container (#40)
aksm-ms Jun 30, 2020
03b0520
Update README.md
N-Usha Jul 3, 2020
010a52f
Fixing typo
aksm-ms Jul 7, 2020
3ab934f
updating webappkind enum (#44)
aksm-ms Jul 14, 2020
1297d15
Moving setresourcedetails into Publish profile container (#47)
aksm-ms Jul 14, 2020
cfca066
Update README.md
orta Jul 27, 2020
311e0e4
Update README.md
aksm-ms Aug 5, 2020
c6e7fdf
Update README.md
aksm-ms Aug 5, 2020
3d7dd06
Update README.md
aksm-ms Aug 5, 2020
a87385e
Update README.md
aksm-ms Aug 5, 2020
ea92ea2
Update README.md
aksm-ms Aug 5, 2020
e985d6f
Merge pull request #55 from Azure/readme-update-master
N-Usha Aug 5, 2020
ee99262
Merge branch 'master' into patch-1
arjgupta Aug 10, 2020
d2c73a2
Merge pull request #53 from orta/patch-1
arjgupta Aug 10, 2020
d2c074d
publish profile for slot deployment
AmrutaKawade Aug 27, 2020
dec3da8
updated document for slot
AmrutaKawade Aug 28, 2020
790dfd5
Merge pull request #57 from Azure/users/amkawade/document
AmrutaKawade Aug 28, 2020
ae4ae5e
Fix private registry credentials example config (#58)
gazab Sep 18, 2020
c6cf55c
Expand explanation of az ad sp create-for-rbac in readme (#65)
kraigb Sep 30, 2020
27f2138
Bump @actions/core from 1.2.1 to 1.2.6
dependabot[bot] Oct 1, 2020
f7acfd4
Create issue-label-bot.yaml
AmrutaKawade Oct 6, 2020
e1970fd
Merge pull request #71 from Azure/AmrutaKawade-patch-1
AmrutaKawade Oct 6, 2020
44613b5
New appkind support (#1)
AmrutaKawade Oct 7, 2020
99cadb2
Merge pull request #68 from Azure/dependabot/npm_and_yarn/actions/cor…
AmrutaKawade Oct 8, 2020
2906c2a
Merge branch 'master' of https://github.com/Azure/webapps-deploy into…
AmrutaKawade Oct 8, 2020
eb0a1b5
Bump lodash from 4.17.15 to 4.17.20 (#72)
dependabot[bot] Oct 12, 2020
0bba27e
Update README.md (#69)
raahmed Oct 20, 2020
c0e50ee
Update README.md (#80)
Nov 3, 2020
2b6ed4a
Update README.md (#82)
aksm-ms Nov 10, 2020
cfa84e3
Fixed a small syntax error in the markdown 😊 (#84)
tevoinea Nov 17, 2020
fbf2c52
Update README.md (#87)
N-Usha Nov 18, 2020
4ac2c00
Make app-name and slot-name as lower case
asranja Dec 7, 2020
a2eeeef
Temp add node_modules
asranja Dec 7, 2020
f430327
audit fix
asranja Dec 7, 2020
f1454e6
update node version
asranja Dec 7, 2020
8d6aaf1
temp commit for test
asranja Dec 7, 2020
1695a77
revert temp commit
asranja Dec 7, 2020
224f145
remove node_modules
asranja Dec 7, 2020
2cfcb58
remove unnecessary file
asranja Dec 7, 2020
2e48ce3
Addressing comment
20shivangi Dec 8, 2020
8b0d752
Merge pull request #91 from Azure/users/asranja/sanitizeinputs
20shivangi Dec 8, 2020
1a466c4
Update issue templates
AmrutaKawade Dec 28, 2020
7e75a53
Updated Readme for webapps-deploy actions (#97)
zainuvk Dec 28, 2020
b062dd0
added logs for multicontainer support (#104)
aksm-ms Jan 13, 2021
db1eced
fix for duplicate duployment issue (#111)
AmrutaKawade Mar 9, 2021
89bdb91
Fix typo in error message (#116)
martincostello Mar 11, 2021
1ae8b44
Bump y18n from 4.0.0 to 4.0.1
dependabot[bot] Apr 1, 2021
71882b8
Creating a workflow to label stale issues and PRs
kaverma Apr 6, 2021
c31d74c
Update stale.yml
kaverma Apr 6, 2021
e809551
Update stale.yml
kaverma Apr 6, 2021
628b803
Updating trigger to run on a schedule only.
kaverma Apr 6, 2021
d557380
Merge pull request #123 from Azure/users/kaverma/stale
kaverma Apr 7, 2021
a98be40
Merge pull request #121 from Azure/dependabot/npm_and_yarn/y18n-4.0.1
kaverma Apr 7, 2021
f427bd4
Update and rename stale.yml to defaultLabels.yml (#153)
BALAGA-GAYATRI Jun 2, 2021
999b35c
Users/balaga gayatri/defaultlabels (#158)
BALAGA-GAYATRI Jun 3, 2021
d98547d
Merge branch 'users/amkawade/kubeapp' into master
BALAGA-GAYATRI Jun 10, 2021
393f751
updating users/amkawade/kubeapp with master (#169) (#170)
BALAGA-GAYATRI Jun 10, 2021
05e3bec
Users/balaga gayatri/multi container master (#171)
BALAGA-GAYATRI Jun 10, 2021
03ca72b
Adding commit message to zipDeploy payload (#127)
BALAGA-GAYATRI Jun 14, 2021
e8fe6d0
Bump ws from 7.3.1 to 7.4.6 (#155)
dependabot[bot] Jun 14, 2021
cbb7f65
Bump hosted-git-info from 2.8.8 to 2.8.9 (#139)
dependabot[bot] Jun 14, 2021
55bb9b7
Bump lodash from 4.17.20 to 4.17.21 (#137)
dependabot[bot] Jun 14, 2021
85c751e
Create CODEOWNERS (#175)
BALAGA-GAYATRI Jun 14, 2021
5b5c613
Remove windowsContainerAppNotAllowedForPublishProfile validator. (#134)
chunye Jun 23, 2021
f4ead19
Fix typo in command name `az ad sp create-for-rbac` (#179)
thibaudcolas Jun 25, 2021
45c59f7
Fix README to mention Windows container can also publish via publishi…
chunye Jun 29, 2021
5604db5
Users/balaga gayatri/prchecksrepo (#163)
BALAGA-GAYATRI Jul 26, 2021
8357b67
Rename CODEOWNERS to CODEOWNER
BALAGA-GAYATRI Aug 4, 2021
433b1b6
Delete CODEOWNER
BALAGA-GAYATRI Aug 4, 2021
8494dd6
Create CODEOWNERS
BALAGA-GAYATRI Aug 5, 2021
19411fa
Rename bug-report---feature-request.md to bug-report-feature-request.md
BALAGA-GAYATRI Aug 9, 2021
0811a07
Update pr_check_webapp_dotnet_windows.yml
BALAGA-GAYATRI Aug 23, 2021
111a285
Update pr_check_windows_container_pubprofile.yml
BALAGA-GAYATRI Aug 23, 2021
fd9f454
Update pr_check_webapp_dotnet_windows.yml
BALAGA-GAYATRI Sep 16, 2021
0b9009a
Update pr_check_windows_container_pubprofile.yml
BALAGA-GAYATRI Sep 16, 2021
bc8bbe0
Update README.md
BALAGA-GAYATRI Oct 28, 2021
4a274aa
Trim commit message to not include description
Methuselah96 Apr 5, 2022
6eebfcd
Updating the workflow files with new resources (#249)
shpraka Sep 2, 2022
70beafb
Update pr_check_windows_container_pubprofile.yml (#250)
shpraka Sep 2, 2022
69a890e
add sample github action yml for go apps on azure app services
Sep 5, 2022
1a288c6
Merge pull request #246 from shubham805/master
shubham805 Sep 5, 2022
131b696
Merge pull request #226 from Methuselah96/trim-commit-message
shubham805 Sep 6, 2022
8adc03f
Added node version 16 in action.yml at line no.35 (#264)
chetan-vaidya3d Nov 25, 2022
e42f3aa
Update @actions/core (#258)
erik-itland Nov 25, 2022
24be858
Limit the length of commit message (#271)
kumaraksh1 Nov 30, 2022
ba99bed
Bump decode-uri-component from 0.2.0 to 0.2.2 (#276)
dependabot[bot] Dec 7, 2022
4126fd5
Add kind *api* to actionparameters.ts (#107)
waeltken Dec 12, 2022
1217efd
Changed the actions-secret-parser version (#280)
shpraka Jan 2, 2023
3bd04a7
Adding Resource Group As Optional Param (#283)
shpraka Jan 11, 2023
79bedf3
Bump json5 from 2.1.3 to 2.2.3 (#281)
dependabot[bot] Jan 11, 2023
7b351df
Update README.md (#287)
shpraka Jan 17, 2023
73e9667
Correcting the typo in go.yml
surenderssm Jan 31, 2023
ce0410a
Merge pull request #290 from Azure/surenderssm-patch-1
surenderssm Feb 1, 2023
c577592
testing
shpraka Feb 14, 2023
fd6b134
reverting last commit
shpraka Feb 14, 2023
20cc095
update azure-actions-appservice-rest version (#295)
shpraka Feb 16, 2023
5e45f8e
Container Registry changed (#299)
shpraka Mar 21, 2023
05ac4e9
Trim commit message (#301)
kumaraksh1 Mar 27, 2023
7d2c9e2
Enhance deployment error in case of 403 (#305)
kumaraksh1 Mar 31, 2023
a9fc696
Git logout in actions workflow (#311)
kumaraksh1 Apr 5, 2023
0684687
Reorder actions in workflow file (#317)
kumaraksh1 Apr 6, 2023
ea4bc8b
Refactor Deployment Error Message (#320)
kumaraksh1 Apr 11, 2023
83fb340
Updating App Service Rest Package version (#325)
shpraka Apr 24, 2023
0070099
Merge remote-tracking branch 'origin/master' into releases/April
shpraka Apr 24, 2023
a3dec39
added node modules
shpraka Apr 24, 2023
9fdc04a
updating the modules
shpraka Apr 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 5 additions & 1 deletion .github/workflows/pr_check_windows_container_pubprofile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ jobs:
- name: Logout from Azure Container Registry
run: |
docker logout env.CONTAINER_REGISTRY
<<<<<<< HEAD
=======

>>>>>>> origin/master
- name: Login to Azure Container Registry
uses: azure/docker-login@v1
with:
Expand Down Expand Up @@ -91,4 +95,4 @@ jobs:
with:
app-name: ${{ env.AZURE_WEBAPP_NAME }} # Replace with your app name
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }}
images: ${{ env.CONTAINER_REGISTRY }}/containerwebapp/canaryreplica:latest
images: ${{ env.CONTAINER_REGISTRY }}/containerwebapp/canaryreplica:latest
2 changes: 1 addition & 1 deletion lib/Utilities/PublishProfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class PublishProfile {
throw new Error("Publish profile does not contain kudu URL");
}
this._creds.uri = `https://${this._creds.uri}`;
this._kuduService = new azure_app_kudu_service_1.Kudu(this._creds.uri, this._creds.username, this._creds.password);
this._kuduService = new azure_app_kudu_service_1.Kudu(this._creds.uri, { username: this._creds.username, password: this._creds.password });
}
catch (error) {
core.error("Failed to fetch credentials from Publish Profile. For more details on how to set publish profile credentials refer https://aka.ms/create-secrets-for-GitHub-workflows");
Expand Down
4 changes: 2 additions & 2 deletions lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ function main() {
isDeploymentSuccess = false;
if (error.statusCode == 403) {
core.setFailed("The deployment to your web app failed with HTTP status code 403. \
Your web app may have networking features enabled which are blocking access (such as Private Endpoints).\
For more information, please follow https://aka.ms/forbidden-deployment-error");
Your web app may have networking features enabled which are blocking access (such as Private Endpoints). \
For more information about deploying to virtual network integrated web apps, please follow https://aka.ms/gha/deploying-to-network-secured-sites");
}
else {
core.setFailed("Deployment Failed, " + error);
Expand Down
13 changes: 12 additions & 1 deletion node_modules/.bin/acorn

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions node_modules/.bin/acorn.cmd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions node_modules/.bin/acorn.ps1

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion node_modules/.bin/atob

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions node_modules/.bin/atob.cmd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions node_modules/.bin/atob.ps1

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion node_modules/.bin/copy

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion node_modules/.bin/copy-cli

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions node_modules/.bin/copy-cli.cmd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions node_modules/.bin/copy-cli.ps1

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions node_modules/.bin/copy.cmd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions node_modules/.bin/copy.ps1

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion node_modules/.bin/decompress-zip

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions node_modules/.bin/decompress-zip.cmd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions node_modules/.bin/decompress-zip.ps1

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion node_modules/.bin/escodegen

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions node_modules/.bin/escodegen.cmd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading