Webview interaction and system webview #126

unpluggedk · 2018-04-26T06:39:28Z

No description provided.

oldalton · 2018-04-29T00:36:50Z

IdentityCore/src/MSIDError.h

+     Interaction required errors occur because of a wide variety of errors
+     returned by the authentication service.
+     */
+    MSIDErrorMismatchedUser             = -52101,


just curious, when is this error returned?

When parameter sets a user, and we force webview to login as a different user.
We handled it as an error in MSAL, we can discuss about this.

nit: can we put errors in increasing order? (MSIDErrorInvalidState is in the middle)

oldalton · 2018-04-29T00:37:03Z

IdentityCore/src/MSIDError.h

+     returned by the authentication service.
+     */
+    MSIDErrorMismatchedUser             = -52101,
+    MSIDErrorNoAuthorizationResponse    = -52102,


nit: no authorization code?

no, it's just url nil response.

oldalton · 2018-04-29T00:37:33Z

IdentityCore/src/MSIDError.h

+    /*!
+     An interactive authentication session failed to start.
+     */
+    MSIDErrorInteractiveSessionStartFailure = -51022,


what is the case when this would happen?

SFAuthenticationSession: when start is called on a cancelled session
SafariViewController, when we can't find the current viewcontroller to present from.

oldalton · 2018-04-29T00:38:04Z

IdentityCore/src/MSIDError.m

@@ -49,3 +49,20 @@
 }


+MSIDErrorCode MSIDErrorCodeForOAuthError(NSString *oauthError, MSIDErrorCode defaultCode)
+{
+    if (oauthError && [oauthError caseInsensitiveCompare:@"invalid_request"] == NSOrderedSame)


We already have this code in token response I think. Can we combine it?

done, i've changed TokenResponse to call this.

oldalton · 2018-04-29T00:39:08Z

IdentityCore/src/oauth2/MSIDRequestParameters.h

@@ -40,5 +40,7 @@

 @property (readwrite) NSString *loginHint;
 @property (readwrite) NSString *extraQueryParameters;
+@property (readwrite) NSString *promptBehavior;


I think prompt behavior was something AAD V1 specific?

It also exists for MSAL in a different value.

case MSALForceLogin : return @{ @"prompt" : @"login" }; case MSALForceConsent : return @{ @"prompt" : @"consent" }; case MSALSelectAccount : return @{ @"prompt" : @"select_account" };

oldalton · 2018-04-29T00:51:37Z

IdentityCore/src/webview/systemWebview/MSIDSFAuthenticationSession.h

-{
-    return nil;
-}
+- (id)initWithURL:(NSURL *)url


nit: id -> instancetype

oldalton · 2018-04-29T00:52:31Z

IdentityCore/src/webview/systemWebview/MSIDSafariViewController.h


-@interface MSIDEmbeddedWebviewRequest : MSIDWebviewRequest
+- (id)initWithURL:(NSURL *)url


nit: id -> instancetype

oldalton · 2018-04-29T00:54:36Z

IdentityCore/src/webview/systemWebview/MSIDSafariViewController.m

+        _url = url;
+        _context = context;
+
+        _safariViewController = [[SFSafariViewController alloc] initWithURL:url entersReaderIfAvailable:NO];


how do we ensure that we're on the main thread?

Good point, I think it is logical that we simply check if we are on main thread when start is called, and return NO if we aren't.

oldalton · 2018-04-29T00:59:48Z

IdentityCore/src/webview/systemWebview/MSIDSafariViewController.h


-@property NSURL *endURL;
-@property NSDictionary *headers;
+@property id<MSIDSystemWebviewResponseDelegate> webviewDelegate;


where is webviewDelegate set? Also, if it will be set in a "wrapper" class, who has reference to this controller, this should be weak.

oldalton · 2018-04-29T01:00:44Z

IdentityCore/src/webview/systemWebview/MSIDSystemWebviewController.m

+    MSIDWebUICompletionHandler _completionHandler;
+
+#ifdef __IPHONE_11_0
+    MSIDSFAuthenticationSession *_authSession;


nit: this is not set anywhere

not a nit, huge mistake :p this should've been set 👍

error_description and a fallback logic on error_subcode.

jasoncoolmax · 2018-05-08T22:24:01Z

IdentityCore/src/webview/MSIDWebviewAuthorization.m

+{
+    if (!s_currentWebSession)
+    {
+        @synchronized([MSIDWebviewAuthorization class])


do we need to include line 104 into the synchronized block? seems it will suffer from race condition otherwise :)

Yes you are right, will change

jasoncoolmax · 2018-05-08T22:28:18Z

IdentityCore/src/webview/MSIDWebviewAuthorization.m

+                 context:(id<MSIDRequestContext>)context
+       completionHandler:(MSIDWebUICompletionHandler)completionHandler
+{
+    if (![self setCurrentWebSession:webviewController])


seems we are not able to setCurrentWebSession successfully for the second time, as there is no code to release s_currentWebSession when a webview call is completed? :)

I've included the session cancelling as discussed before

jasoncoolmax · 2018-05-08T22:33:49Z

IdentityCore/src/webview/MSIDWebviewAuthorization.m

+        NSError *error = MSIDCreateError(MSIDErrorDomain, MSIDErrorInteractiveSessionStartFailure, @"Interactive web session failed to start.", nil, nil, nil, context.correlationId, nil);
+
+        completionHandler(nil, error);
+    }


Since we have already passed completionHandler to system/embedded webview, shall we let the webview class to call the completion block if it fails to start?
The start action is kind of async because it involves UI/main thread, it may not be able to return a value immediately to indicate if the start action succeeds :)

Discussed with JK offline, embedded webview will return YES for the start method, to avoid the completion block being called twice :)

session as a completion block.

…tion-library-common-for-objc into jak/system_webview

…zureAD/microsoft-authentication-library-common-for-objc into jak/system_webview

…tion-library-common-for-objc into jak/system_webview

update unit tests and bug fixes

oldalton

Just some additional questions and comments. Looking good otherwise, I'm fine merging it after those comments are addressed and commented out tests are either removed or fixed. We should also add an action item to add more logs to this, but we can do in in a separate PR :)

oldalton · 2018-06-07T03:42:05Z

IdentityCore/src/MSIDError.m

+    }
+    if (oauthError && [oauthError caseInsensitiveCompare:@"invalid_scope"] == NSOrderedSame)
+    {
+        return MSIDErrorInvalidParameter;


nit: should we be more specific about which parameter is invalid?

oldalton · 2018-06-07T03:42:56Z

IdentityCore/src/configuration/MSIDConfiguration.h

@@ -24,13 +24,19 @@
 #import <Foundation/Foundation.h>
 #import "MSIDNetworkConfiguration.h"

+@class MSIDPkce;
+@class MSIDClientInfo;


nit: if MSIDClientInfo is not necessary, please remove this :)

oldalton · 2018-06-07T03:44:42Z

IdentityCore/src/configuration/webview/MSIDWebviewConfiguration.h

-@property (readwrite) MSIDClientInfo *clientInfo;
+
+// User information
+@property (readwrite) NSString *utid;


why this is necessary?

it is used in the param settings for v2

oldalton · 2018-06-07T03:45:13Z

IdentityCore/src/configuration/webview/MSIDWebviewConfiguration.h


 // Priority start URL
 @property (readwrite) NSURL *explicitStartURL;

+- (instancetype)initWithAuthority:(NSURL *)authority


just for me to know, why do we need both authority and authorizationEndpoint, shouldn't authorizationEndpoint be enough?

changed according to offline discussion : MSIDWebviewConfig is different enough to be its own class, not a subclass.

oldalton · 2018-06-07T03:45:56Z

IdentityCore/src/configuration/webview/MSIDWebviewConfiguration.h

+                    correlationId:(NSUUID *)correlationId;
+
+- (instancetype)initWithAuthority:(NSURL *)authority redirectUri:(NSString *)redirectUri clientId:(NSString *)clientId target:(NSString *)target correlationId:(NSUUID *)correlationId NS_UNAVAILABLE;
+- (instancetype)initWithAuthority:(NSURL *)authority redirectUri:(NSString *)redirectUri clientId:(NSString *)clientId target:(NSString *)target NS_UNAVAILABLE;


feels a bit awkward that both of those are unavailable, yet it's a subclass of MSIDConfiguration.

Will be removed - no longer a subclass.

oldalton · 2018-06-07T04:12:24Z

IdentityCore/src/webview/response/MSIDWebviewResponse.m

+    if (!url)
+    {
+        if (error){
+            *error = MSIDCreateError(MSIDOAuthErrorDomain, MSIDErrorInvalidParameter, @"Trying to create a response with nil", nil, nil, nil, context.correlationId, nil);


nit: with nil "url"

oldalton · 2018-06-07T04:13:33Z

IdentityCore/src/webview/systemWebview/MSIDSFAuthenticationSession.m

+    if (@available(iOS 11.0, *))
+    {
+        _authSession = [[SFAuthenticationSession alloc] initWithURL:_startURL
+                                                  callbackURLScheme:_callbackURLScheme


do we pass full redirectUri in here?

Scheme here should be enough

oldalton · 2018-06-07T04:17:17Z

IdentityCore/src/webview/systemWebview/MSIDSystemWebviewController.m

+    MSIDSFAuthenticationSession *_authSession;
+    MSIDSafariViewController *_safariViewController;
+
+    MSIDOauth2Factory *_factory;


where's factory being set?

nowhere, removed

oldalton · 2018-06-07T04:18:05Z

IdentityCore/src/webview/systemWebview/MSIDSystemWebviewController.m

 - (void)cancel
 {
+    if (@available(iOS 11.0, *))


nit: both session and safariViewController conform to the same protocol, don't they?

yeah, I could change this to remove this unnecessary check.

oldalton · 2018-06-07T04:18:43Z

IdentityCore/src/webview/systemWebview/MSIDSystemWebviewController.m

+        return NO;
+    }
+
+    if (@available(iOS 11.0, *)) { return NO; }


nit: should this be yes as we don't have anything to handle?

no, it should be no if we don't handle it.
think about it from this angle,
it app delegate, it will do something like
return microsoft_url_handle || other_url_handle

- remove unnecessary properties from MSIDConfiguration - update testing - update how pkce is handled - update MSIDNetworkConfiguration to be only consist of class properties - address nits and comments

antrix1989 · 2018-06-11T17:23:59Z

IdentityCore/src/configuration/MSIDNetworkConfiguration.m

-        _retryCount = s_defaultRetryCount;
-    }
-    return self;
+    s_timeout = timeout;


Maybe it is better to have default timeout & retryCount setter & getters and assign default values to them in initializer? In such case you will not need to override setters & getters.

these are class properties, which means they don't have default synthesizer.
thus, we'd need to write a setter/getter anyways. so, with that, I don't see a need for an initializer.

antrix1989 · 2018-06-11T17:27:23Z

IdentityCore/src/configuration/MSIDNetworkConfiguration.h

@@ -24,11 +24,9 @@
 #import <Foundation/Foundation.h>


-@interface MSIDNetworkConfiguration : NSObject <NSCopying>
+@interface MSIDNetworkConfiguration : NSObject


Should MSIDNetworkConfiguration be singleton? If no, how are we going to access it in the code?

Both it's properties are class properties with setters and getters.
So, you'd just use MSIDNetworkConfiguration.timeout and MSIDNetworkConfiguration.retryCount

https://developer.apple.com/videos/play/wwdc2016/405/ at 5:07 for reference.

jasoncoolmax · 2018-06-12T18:14:06Z

IdentityCore/src/oauth2/aad_base/MSIDAADWebviewFactory.m

+    if (configuration.sliceParameters)
+    {
+        [parameters addEntriesFromDictionary:configuration.sliceParameters];
+    }


We already add slice parameters at line 38 :)

jasoncoolmax · 2018-06-12T18:56:11Z

IdentityCore/src/webview/MSIDWebviewAuthorization.m

+         verifyState:(BOOL)verifyState 
+             context:(id<MSIDRequestContext>)context
+   completionHandler:(MSIDWebviewAuthCompletionHandler)completionHandler
+{


parameter verifyState is no longer used in this function anymore :)

Right, it is already in the configuration. let me remove.

oldalton · 2018-06-12T19:49:58Z

IdentityCore/IdentityCore.xcodeproj/project.pbxproj

@@ -2823,7 +3042,7 @@
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
 				INFOPLIST_FILE = MSIDTestsHostApp/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 10.3;


Why did we change deployment target?

oldalton · 2018-06-12T19:56:52Z

IdentityCore/src/MSIDError.h

    MSIDErrorUnsupportedFunctionality = -51018,
+


both MSIDErrorInvalidParameter = -51018, and MSIDErrorUnsupportedFunctionality = -51018 are -51018?

Let's address errors in a separate PR

jasoncoolmax · 2018-06-12T20:17:59Z

IdentityCore/src/oauth2/aad_base/MSIDAADWebviewFactory.m

+    }
+
+    NSMutableOrderedSet<NSString *> *allScopes = parameters[MSID_OAUTH2_SCOPE].scopeSet.mutableCopy;
+    [allScopes addObject:MSID_OAUTH2_SCOPE_OPENID_VALUE];


For V1, no scopes are passed in, thenallScopes will be nil? :)

Good point, we should address it :)

oldalton · 2018-06-12T22:18:39Z

IdentityCore/src/configuration/MSIDConfiguration.m

@@ -33,27 +34,15 @@ - (instancetype)copyWithZone:(NSZone*)zone
    configuration.redirectUri = [_redirectUri copyWithZone:zone];
    configuration.target = [_target copyWithZone:zone];
    configuration.clientId = [_clientId copyWithZone:zone];
-    configuration.correlationId = [_correlationId copyWithZone:zone];
-    configuration.loginHint = [_loginHint copyWithZone:zone];
-    configuration.sliceParameters = [_sliceParameters copyWithZone:zone];


I think we need slice parameters for all requests, both interactive and silent

I think it is to be determined whether it will use MSIDConfiguration class or not.

oldalton · 2018-06-12T22:21:55Z

IdentityCore/src/configuration/webview/MSIDWebviewConfiguration.h

-@property (readwrite) NSString *requestState;
+// State verifier: Recommended verifier for state value of the response.
+//  Set to YES to stop if verifying state fails
+@property (readwrite) BOOL verifyState;


nit: I'd prefer verify state to be set on initialize, so nobody can change it in the middle of authentication.

sounds logical. will change accordingly.

oldalton · 2018-06-12T22:22:10Z

IdentityCore/src/oauth2/MSIDOauth2Factory.h

-                                                     customWebview:(WKWebView *)webview;
- (id<MSIDWebviewInteracting>)systemWebviewControllerWithRequest:(MSIDConfiguration *)requestParams;
+// Webview related
+@property(readonly) MSIDWebviewFactory *webviewFactory;


oldalton · 2018-06-12T22:27:57Z

IdentityCore/src/oauth2/MSIDWebviewFactory.m

+
+- (NSString *)generateStateValue
+{
+    return [[NSUUID UUID] UUIDString];


oldalton · 2018-06-12T22:28:16Z

IdentityCore/src/oauth2/aad_base/MSIDAADOauth2Factory.m

+{
+    if (!_webviewFactory)
+    {
+        _webviewFactory = [[MSIDAADWebviewFactory alloc] init];


nit: do we need to do it in each subclass?

they create different type of webview factory

oldalton · 2018-06-12T22:28:55Z

IdentityCore/src/oauth2/aad_base/MSIDAADWebviewFactory.m

+    }
+
+    NSMutableOrderedSet<NSString *> *allScopes = parameters[MSID_OAUTH2_SCOPE].scopeSet.mutableCopy;
+    [allScopes addObject:MSID_OAUTH2_SCOPE_OPENID_VALUE];


Good point, we should address it :)

oldalton · 2018-06-12T22:29:31Z

IdentityCore/src/oauth2/aad_base/MSIDAADWebviewFactory.m

+    {
+        [parameters addEntriesFromDictionary:
+         @{
+           MSID_OAUTH2_CORRELATION_ID_REQUEST : @"true",


I'm just curious why is this necessary?

It was in x-plat libraries as well as our ADAL.

From MSDN, https://msdn.microsoft.com/en-us/library/mt739779.aspx

2.2.1.2 return-client-request-id
The return-client-request-id HTTP header is optional. This header is sent in the request and is used by the key provisioning server to determine whether to return the client-specified client-request-id in the server response. If present, the value of the return-client-request-id header MUST be "true".

The format of the return-client-request-id header, in ABNF, is as follows.

return-client-request-id = "true"

oldalton · 2018-06-12T22:31:01Z

IdentityCore/src/util/NSDictionary+MSIDExtensions.m

@@ -94,4 +94,22 @@ - (NSDictionary *)dictionaryByRemovingFields:(NSArray *)fieldsToRemove
    return mutableDict;
 }

+- (NSArray<NSURLQueryItem *> *)urlQueryItemsArray;


just curious, where is this being used?
and nit: there's a ";" in the end

we use this constructing startURL.

urlComponents.queryItems = [parameters urlQueryItemsArray];

oldalton · 2018-06-12T22:31:54Z

IdentityCore/src/util/NSString+MSIDExtensions.m

+//        [toReturn appendFormat:@"%02x", hash[i]];
+//    }
+//    return toReturn;
+    return [NSString msidBase64UrlEncodeData:[self msalSHA256Data]];


oldalton

I'm fine merging it after previous nit comments are addressed. This PR has grown way too much :)

oldalton · 2018-06-12T22:47:36Z

IdentityCore/tests/MSIDWebOAuth2ResponseTests.m

+    urlComponents.queryItems = @{
+                                 MSID_OAUTH2_ERROR : errorString,
+                                 MSID_OAUTH2_ERROR_DESCRIPTION : errorDescription,
+                                 MSID_OAUTH2_SUB_ERROR : subError,


do we also have a test for the "subcode" scenario?

I don't think so. The only place where it made sense was when a developer clicks on a back button on the webview itself.
By passing haschrome=1, there no longer is the back button and thus, we are fine without.

oldalton · 2018-06-12T22:48:59Z

IdentityCore/tests/MSIDAADV2Oauth2FactoryTests.m

@@ -417,5 +421,112 @@ - (void)testAccountFromTokenResponse_whenAADV2TokenResponse_shouldInitAccountAnd
    XCTAssertEqualObjects(account.authority.absoluteString, @"https://login.microsoftonline.com/contoso.com");
 }

+#pragma mark - Webview (StartURL)
+//- (void)testStartURL_whenValidParams_shouldContainQPs


if this code is not necessary, let's remove it :)

and other nits

…tion-library-common-for-objc into system_webview

unpluggedk added 3 commits April 20, 2018 17:11

add some more definitions. subject to change.

5f61177

updating msidwebviewauthorization to have start instead of init

e905d25

initial implementation of webview interactive session.

ba71b3d

unpluggedk requested review from jasoncoolmax and oldalton April 26, 2018 06:39

unpluggedk added 3 commits April 27, 2018 18:25

updating system webview controller in handling response

fc1d8db

bring in pkce and make changes to how system webviews work

f29dcb3

add urlQueryItemsArray in NSDictionary extension

c669afe

oldalton reviewed Apr 29, 2018

View reviewed changes

unpluggedk added 12 commits April 29, 2018 01:55

address comments

d8813b5

more of addresssing comments

c8c826f

refactor web auth response logic

4dd6ec6

refactor response creation

d987e60

update project settings

8c99592

system webview flow functionally 'in place'

d99bc6f

preprocessors for mac vs iphone targets in system webview

10aae32

type fix: msal prefix to msid prefix

0e34d81

readdress header imports

9e7fb0b

refactoring

0bd3d7f

revise sha256 method - incorrect implementation in adal perhaps?

7b5255b

update oauth error handling, for now a hack to get suberror from

69e15a1

error_description and a fallback logic on error_subcode.

unpluggedk force-pushed the jak/system_webview branch from 5a5c632 to 69e15a1 Compare May 4, 2018 21:40

jasoncoolmax reviewed May 8, 2018

View reviewed changes

unpluggedk added 5 commits May 8, 2018 16:55

revise synchronized handling for session, and add clearing of the

fbbb81e

session as a completion block.

fix tests

c5675ec

Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…

f1207ee

…tion-library-common-for-objc into jak/system_webview

replace idtoken string parameter into uid/utid

d58eed6

update project files and some to make mac test build work

6f737f0

unpluggedk added 14 commits May 23, 2018 17:54

checkpoint: update flow as discussed

b31e99f

Merge branch 'oldalton/msal_updates_to_cache' of https://github.com/A…

8718d82

…zureAD/microsoft-authentication-library-common-for-objc into jak/system_webview

Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…

a9cff24

…tion-library-common-for-objc into jak/system_webview

update the flow - revise how request state is being passed around

1ea816d

refactor for improvements. unit tests need to be fixed.

7b8979c

minor bug fix - saferi viewcontroller reset upon completion

7d9ed31

adding unit testing after changes and some minor fixes

58b7c6a

move testcacheIdentifiers to testIdentifiers.

dad2296

update unit tests and bug fixes

revise start of web interactive session to return void than BOOL

9801600

update mock webview controller

9d505c8

state verification to have a terminating conditional

97ddaa1

fix returning error at start webview

9ec3d45

separate webview factory and revised response handling

804186a

add unit testing and minor fixes

17834c5

oldalton reviewed Jun 7, 2018

View reviewed changes

oldalton requested a review from antrix1989 June 7, 2018 04:24

- MSIDWebviewConfiguration no longer inherits from MSIDConfiguration.

e5da20a

- remove unnecessary properties from MSIDConfiguration - update testing - update how pkce is handled - update MSIDNetworkConfiguration to be only consist of class properties - address nits and comments

antrix1989 reviewed Jun 11, 2018

View reviewed changes

address rest of the comments

865eff9

jasoncoolmax reviewed Jun 12, 2018

View reviewed changes

oldalton reviewed Jun 12, 2018

View reviewed changes

jasoncoolmax reviewed Jun 12, 2018

View reviewed changes

oldalton reviewed Jun 12, 2018

View reviewed changes

oldalton approved these changes Jun 12, 2018

View reviewed changes

unpluggedk added 2 commits June 14, 2018 11:26

addressing feedback: remove stateVerifier flag for places unnecessary,

185db0d

and other nits

Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…

6183514

…tion-library-common-for-objc into system_webview

unpluggedk merged commit 9825466 into dev Jun 16, 2018


		@interface MSIDEmbeddedWebviewRequest : MSIDWebviewRequest
		- (id)initWithURL:(NSURL *)url

Webview interaction and system webview #126

Webview interaction and system webview #126

Conversation

unpluggedk commented Apr 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasoncoolmax May 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oldalton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oldalton Jun 7, 2018 • edited Loading

Choose a reason for hiding this comment

unpluggedk Jun 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unpluggedk Jun 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasoncoolmax Jun 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasoncoolmax May 8, 2018 •

edited

Loading

oldalton Jun 7, 2018 •

edited

Loading

unpluggedk Jun 7, 2018 •

edited

Loading

unpluggedk Jun 14, 2018 •

edited

Loading

jasoncoolmax Jun 12, 2018 •

edited

Loading