Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error code & other related tasks refactoring #153

Merged
merged 21 commits into from
Jun 26, 2018
Merged

Error code & other related tasks refactoring #153

merged 21 commits into from
Jun 26, 2018

Commits on Jun 18, 2018

  1. revise error codes

    @unpluggedk
    unpluggedk committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    59dedf2 View commit details
    Browse the repository at this point in the history

  2. re-add codeFirst and last for boundary checks

    @unpluggedk
    unpluggedk committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    5305f64 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2018

  1. address feedback

    @unpluggedk
    unpluggedk committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    1370486 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica… 

    …tion-library-common-for-objc into jak/error-coding
    @unpluggedk
    unpluggedk committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    fb06c85 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2018

  1. update project file and error codes (MSAL tested)

    @unpluggedk
    unpluggedk committed Jun 23, 2018
    Configuration menu
    Copy the full SHA
    1a4a89f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2018

  1. additional conditional checks for disabling system webview from 

    included.
    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    79f415f View commit details
    Browse the repository at this point in the history

  2. minor typo

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    26fcc80 View commit details
    Browse the repository at this point in the history

  3. additional conditionals to fix unit tests

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    d26da5a View commit details
    Browse the repository at this point in the history

  4. add conditional checker for importing additional xcconfig

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    258ce69 View commit details
    Browse the repository at this point in the history

  5. separate authority validation failure from server error

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    f383235 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'jak/error-coding' of https://github.com/AzureAD/microso… 

    …ft-authentication-library-common-for-objc into jak/additional-integration-fixes
    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    abb22c7 View commit details
    Browse the repository at this point in the history

  7. separate embedded webview cancel to user cancel and app cancel

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    92ec263 View commit details
    Browse the repository at this point in the history

  8. report error at auth session cancellation programatically.

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    f14de0e View commit details
    Browse the repository at this point in the history

  9. fix error to have right domain

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    d49dd2e View commit details
    Browse the repository at this point in the history

  10. address more code refactoring

    @unpluggedk
    unpluggedk committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    bbd6375 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2018

  1. minor fix after MSAL integration

    @unpluggedk
    unpluggedk committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    6b87210 View commit details
    Browse the repository at this point in the history

  2. rework numbers for easier addition in future, and minor adjustment after 

    ADAL integration.
    @unpluggedk
    unpluggedk committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    3672f38 View commit details
    Browse the repository at this point in the history

  3. fix unit test

    @unpluggedk
    unpluggedk committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    3117678 View commit details
    Browse the repository at this point in the history

  4. address comments

    @unpluggedk
    unpluggedk committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    089ec9f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica… 

    …tion-library-common-for-objc into jak/error-coding
    @unpluggedk
    unpluggedk committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    9acc5b8 View commit details
    Browse the repository at this point in the history

  6. typo on MSIDErrorSessionCanceledProgramatically

    @unpluggedk
    unpluggedk committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    330fcd8 View commit details
    Browse the repository at this point in the history